Collapsable items not work with jQuery 1.2.1

VladSavitsky - November 22, 2007 - 11:46
Project:Simple Karma
Version:5.x-1.x-dev
Component:Code
Category:support request
Priority:normal
Assigned:VladSavitsky
Status:closed
Description

I was replaced a jquery.js with one's located in Simple Karma folder as asked in Install.txt.
If JS is on - collapsable items not opens. They even not a link and not clickable anymore. What can I do to fix it?
Thanks.

#1

Snowflake1 - November 22, 2007 - 12:17
Status:active» fixed

Actually you can install the Jquery Update module. You will get an error message in your admin menu (because you are using Jquery 1.2.1 instead of the file that comes with the module) but the module does fix the collapsable item problem. Please check on your end.

#2

mercmobily - November 22, 2007 - 13:40
Status:fixed» active

Hi,

It's a little weird, that I re-open this bug myself. But, I noticed it and it's bother me as well. It will stay open till we have a _clear_ fix.
Showflake, what did you actually do to fix the non-collapsing items?
I don't think they work with JQuery 1.2.1... So, I wonder what we should do (the module needs to keep Drupal at least usable, at least in its core)

Bye,

Merc.

#3

Snowflake1 - November 22, 2007 - 14:02

Simply install the Jquery Update module but do not replace the Jquery file with the one that comes with the module (keep Jquery 1.2.1). You will unfortunately get an error message in your admin menu but the module does fix the collapsable item issue.

#4

Snowflake1 - November 22, 2007 - 14:04

#5

mercmobily - November 22, 2007 - 14:07

Hi,

Question: How will it fix it, and why?
I mean... if Drual has the "wrong" query installed, what does this do to Drupal to make the menus work...?

Merc.

#6

mercmobily - November 22, 2007 - 14:18

Hi,

I think I fixed this one for real...
If I remember this correctly, the collapsible stuff didn't collapse, but opened fine when clicked.
I fixed a slight bug in CVS with our javascript (there was still a reference to the function that hid voted down comments). So, now the javascript can run.

De-collapsing works (which is very important). Re-collapsing doesn't. I've asked Alan to look into it, but I am not gonna consider it major - just one of the many minor quirks you get because of the fact that we're using JQuery 1.2.1...

Bye,

Merc.

#7

VladSavitsky - November 22, 2007 - 21:03

I'm trying new CVS version...
Just a suggestion:
Replace in install.txt:

<? print simple_karma_insert_js_css();?>

with

<?php
if(module_exists('simple_karma')){ print simple_karma_insert_js_css(); }
?>

Because when I simply remove SK I get a fatal error and need to fix this by hand:

Fatal error: Unknown function: simple_karma_insert_js_css() in /var/www/html/ekklesia/sites/all/themes/zen.abac/page.tpl.php on line 10

Better way to replace it with condition. Thanks.

I have tryid jQuery Update module and new CVS-version of Simple Karma and see the same. Looks like JS disabled (JS was really enebled). Look at screenshot, please

AttachmentSize
karma7.png 15.08 KB

#8

mercmobily - November 23, 2007 - 00:38

Hi,

I really have fixed this one, VladSavitsky ...
Please:

* Make sure you refresh the JS install firebug and make sure it doesn't give an error

* Make sure you refresh to the latest version of simple_karma.js

* Show me the result of "View page source" for the file "simple_karma.js" (NOT what's on your server). You can find the path to this file by doing "view page source" of ANY page in a site with simple_karma

...and report back.
I have just reinstalled a fewsh D5.3 with SK and de-collapsing works (although re-collapsing doesn't, but that's not _really_ a huge problem)

Bye,

Merc.

#9

Snowflake1 - November 23, 2007 - 09:02

"I'm trying new CVS version...
Just a suggestion:
Replace in install.txt:

<? print simple_karma_insert_js_css();?>

with

<?php
if(module_exists('simple_karma')){ print simple_karma_insert_js_css(); }
?>

Because when I simply remove SK I get a fatal error and need to fix this by hand:
Fatal error: Unknown function: simple_karma_insert_js_css() in /var/www/html/ekklesia/sites/all/themes/zen.abac/page.tpl.php on line 10

Better way to replace it with condition. Thanks."

Totally agree, when I turned off Simple Karma, my whole site was down with fatal error. Much better with a condition.

And the thing is: I had the same issue with collapsable items however installing and enabling the Jquery update module does work for me. Everything works perfectly, collapsing/recollapsing etc. The important file contained in the module that fixes this bug is collapse-fix.js I think. Can just try using that fix without the module if you know how I guess.

#10

mercmobily - November 23, 2007 - 13:43
Status:active» closed

Hi,

That is totally true - collapse-fix.js actually fixes the collapsing.
I was tempted to add it to this module. But... it wouldn't make _that_ much sense, and it would clash with people using the jquery-update module.
So, I will consider this issue *closed*, since the de-collapsing work on my local system and that these issues will disappear with D6.

Bye,

Merc.

#11

VladSavitsky - November 24, 2007 - 10:45

Yes. Now it works. Thanks.

#12

bobdalob - November 28, 2007 - 21:18

Re: jquery_update module & jquery v1.2.1

You will unfortunately get an error message in your admin menu but the module does fix the collapsable item issue

I've just posted this. Hope it helps.

 
 

Drupal is a registered trademark of Dries Buytaert.