Expand the Bulk Revert page to select which specific meta tags to remove rather than removing all meta tags.

CommentFileSizeAuthor
#6 metatag-n1944862-6.patch8.03 KBdamienmckenna
#5 1944862-05-metatag-bulk-revert-by-tag.patch5.35 KBfeyp
#3 1944862-03-metatag-bulk-revert-by-tag.patch6.25 KBfeyp

Comments

cposer’s picture

cposer commented
Issue summary: View changes

Bump.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Unless someone submits a patch, this will not make it into 1.0.

feyp’s picture

feyp commented
Status: Active » Needs review
StatusFileSize
new 1944862-03-metatag-bulk-revert-by-tag.patch6.25 KB

Attached is a patch against 7.x-1.x.

I'm not sure, if LANGUAGE_NONE needs to be added to the list of languages as it isn't returned by language_list(). In my dev environment, all tags were associated with a specific language.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

This is great, thanks! One minor thing - I don't think the language selection and tag selection should be tied together, I think it should be possible to revert a specific meta tag for all languages, or all meta tags for a specific language.

feyp’s picture

feyp commented
Status: Needs work » Needs review
StatusFileSize
new 1944862-05-metatag-bulk-revert-by-tag.patch5.35 KB

Yes, you're right. I wonder, why I didn't implement it in the first place ;). Attached is an updated version of the patch.

I also checked a few production systems and there were metatags associated with LANGUAGE_NONE, so I added that to the language options.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n1944862-6.patch8.03 KB

This adds some tests to confirm the form fields load as intended.

  • DamienMcKenna committed 6b90fe1 on 7.x-1.x authored by FeyP 
    Issue #1944862 by FeyP, DamienMcKenna: Allow control over which meta...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Parent issue: » #2758749: Plan for Metatag 7.x-1.18 release

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.