While reviewing #1872876: Turn role permission assignments into configuration., I noticed that the current implementation throws notices, and we have no coverage for it.
This could go in before or after that issue, it doesn't matter.

CommentFileSizeAuthor
#16 vdc-1944923-9.patch5.47 KBr.nabiullin
#11 vdc-1944922.patch10.5 KBdawehner
#8 vdc-1944922-8.patch10.38 KBdawehner
#4 vdc-1944922-4-FAIL.patch5.35 KBtim.plunkett
#4 vdc-1944922-4-PASS.patch10.39 KBtim.plunkett
node-views-analyze-PASS.patch5.68 KBtim.plunkett
node-views-analyze-FAIL.patch4.16 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +VDC

Tagging.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/node/lib/Drupal/node/Tests/Views/AnalyzeNodeTest.phpundefined
@@ -0,0 +1,69 @@
+    $this->drupalLogin($this->drupalCreateUser(array('administer views')));
+    $this->drupalGet('admin/structure/views/nojs/analyze/test_node_analyze/page_1');
+    $this->assertRaw(t('Some roles lack permission to access content, but display %display has no access control.', array('%display' => 'Master')));
+    $this->assertRaw(t('Display %display has no access control but does not contain a filter for published nodes.', array('%display' => 'Master')));
+    $this->assertRaw(t('Display %display has set node/% as path. This will not produce what you want. If you want to have multiple versions of the node view, use panels.', array('%display' => 'Page')));

Can't we directly access the analyzer, so we could even in theory use ViewUnitTestBase?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » tim.plunkett
Status: Needs review » Postponed

Yep, will do. Also we might as well wait for the other issue.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: tim.plunkett » Unassigned
Status: Postponed » Needs review
StatusFileSize
new vdc-1944922-4-PASS.patch10.39 KB
new vdc-1944922-4-FAIL.patch5.35 KB

Okay! That's in. Most of the fixes are in, except the hook is in the wrong file.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, vdc-1944922-4-PASS.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
Issue tags: +VDC

#4: vdc-1944922-4-PASS.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/modules/node/node.views.incundefined
@@ -670,3 +670,44 @@ function node_views_plugins_row_alter(array &$plugins) {
+      if ($display->getOption('path') == 'node/%node') {

+++ b/core/modules/node/node.views_execution.incundefined
@@ -17,44 +17,3 @@ function node_views_query_substitutions(ViewExecutable $view) {
-      if ($display->getOption('path') == 'node/%') {

This is a chance. Are you sure users configure node/%node as path? I doubt that.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new vdc-1944922-8.patch10.38 KB

There we go.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, vdc-1944922-8.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Component: node.module » node system
Issue summary: View changes

(Merging "node system" and "node.module" components for 8.x; disregard.)

dawehner’s picture

dawehner
Primary language German
commented
Component: node system » ajax system
Status: Needs work » Needs review
Issue tags: +VDC
StatusFileSize
new vdc-1944922.patch10.5 KB

Everytime someone changes an issue component without actually reviewing an existing patch someone kills a kitten.

Status: Needs review » Needs work

The last submitted patch, 11: vdc-1944922.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Component: ajax system » node system

Why is it that mostly our issues got bit by this. :P

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

11: vdc-1944922.patch queued for re-testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
r.nabiullin’s picture

r.nabiullin commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new vdc-1944923-9.patch5.47 KB

Rerolled patch from comment #11

Status: Needs review » Needs work

The last submitted patch, 16: vdc-1944923-9.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

acbramley’s picture

acbramley commented
Status: Needs work » Closed (outdated)

We have NodeViewsAnalyzeTest now