Nofollowlist is adding nofollow rules to my relative paths! (/news/index.html) Is there a way to exlude the "nofollow" rule from relative paths?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 194513_relative_urls_local.patch | 922 bytes | greggles |
| #2 | relative_links.patch | 572 bytes | artem_sokolov |
Comments
Comment #1
gregglesI don't see how feature requests can be critical unless someone is willing to write a patch or sponsor a bounty so I'm downgrading this unless you want to provide one of those.
I can imagine that one solution to this is to check for {href="http} before running the code that adds nofollow.
Comment #2
artem_sokolov commentedHere is the patch for 6.x-1.0.
Possibly not a best solution - I accomplished this by assigning
$base_urlto$url['host']before checking against white/black lists is done.Comment #3
gregglesThanks, artem_sokolov!
@Xabi - can you test this patch? It is against 6.x but the modules are very similar form 6.x to 5.x
Comment #4
mfm commentedPatch tested and confirmed working! Drupal 6.10 with Nofollowlist 6.x-1.0
Running 5 days now, no problems occured so far.
Comment #5
willdashwood commentedJust to add my 2 cents, this patched worked fine for me too once I'd cleared my cache. Thanks artem_sokolov!
Comment #6
gregglesDid anyone try this with Drupal in a sub-directory?
I'm ready to commit it, but would like to know that it works in that situation.
I've updated it to follow the coding standards.
Comment #7
rsvelko commentedI tested on a subdir 6.12 site with the latest stable of nofollowlist:
with and without the patch when I whitelist just the domain (segments.at) it works as expected - see http://segments.at/sonja/de/09/05/22/test-nofollow-links
So I guess that the issue was with drupal 5 initially - I suggest the maintainer commit this one line patch and mark it as fixed.
If some of the 5.x guys has still this problem let them reopen.
Repeat: in a subdir 6.10 all works fine. Caches were cleared each time.
Comment #8
gregglesGreat, committed to 6.x http://drupal.org/cvs?commit=215120
Thanks, artem_sokolov for the patch and rsvelko for the tests!
Comment #10
stevethewebguy commentedThis worked for me, thanks!
Comment #11
superflyman commentedWill this be added to the official release or will it remain in dev? Please advise. Thanks!
Comment #12
gregglesI'd like to fix #475340: Add nofollow to some internal links first and then make a new release. Can you help review that?
Comment #13
superflyman commented@greggles
I would be happy to help test this.... Just point me in the right direction. Thanks-