Nofollowlist is adding nofollow rules to my relative paths! (/news/index.html) Is there a way to exlude the "nofollow" rule from relative paths?

Comments

greggles’s picture

Priority: Critical » Normal

I don't see how feature requests can be critical unless someone is willing to write a patch or sponsor a bounty so I'm downgrading this unless you want to provide one of those.

I can imagine that one solution to this is to check for {href="http} before running the code that adds nofollow.

artem_sokolov’s picture

Version: 5.x-1.x-dev » 6.x-1.0
Status: Active » Needs review
StatusFileSize
new572 bytes

Here is the patch for 6.x-1.0.
Possibly not a best solution - I accomplished this by assigning $base_url to $url['host'] before checking against white/black lists is done.

greggles’s picture

Thanks, artem_sokolov!

@Xabi - can you test this patch? It is against 6.x but the modules are very similar form 6.x to 5.x

mfm’s picture

Patch tested and confirmed working! Drupal 6.10 with Nofollowlist 6.x-1.0

Running 5 days now, no problems occured so far.

willdashwood’s picture

Just to add my 2 cents, this patched worked fine for me too once I'd cleared my cache. Thanks artem_sokolov!

greggles’s picture

StatusFileSize
new922 bytes

Did anyone try this with Drupal in a sub-directory?

I'm ready to commit it, but would like to know that it works in that situation.

I've updated it to follow the coding standards.

rsvelko’s picture

Status: Needs review » Reviewed & tested by the community

I tested on a subdir 6.12 site with the latest stable of nofollowlist:

with and without the patch when I whitelist just the domain (segments.at) it works as expected - see http://segments.at/sonja/de/09/05/22/test-nofollow-links

So I guess that the issue was with drupal 5 initially - I suggest the maintainer commit this one line patch and mark it as fixed.

If some of the 5.x guys has still this problem let them reopen.

Repeat: in a subdir 6.10 all works fine. Caches were cleared each time.

greggles’s picture

Status: Reviewed & tested by the community » Fixed

Great, committed to 6.x http://drupal.org/cvs?commit=215120

Thanks, artem_sokolov for the patch and rsvelko for the tests!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

stevethewebguy’s picture

This worked for me, thanks!

superflyman’s picture

Will this be added to the official release or will it remain in dev? Please advise. Thanks!

greggles’s picture

I'd like to fix #475340: Add nofollow to some internal links first and then make a new release. Can you help review that?

superflyman’s picture

@greggles

I would be happy to help test this.... Just point me in the right direction. Thanks-