After implementing #1710258: More than 2 Time Blocks Per Day: upgrade to 21, 28... hours per week, the following tasks are left.
- implement better widget
- implement hook-update_N(), to normalize existing field settings;
- implement hook-update_N(), to normalize column 'day' to 'normal' day numbers;
- update javascript so that
a) first empty time block contains 'Add more hours' link (initially the second one for each day) , and
b) all following (3rd, 4th, etc.) are hidden.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | hide_additional_add_hours-1945230-2.patch | 1.92 KB | kpaxman |
Comments
Comment #1
johnvUpdated issue summary, better title.
Comment #1.0
johnvUpdated status
Comment #2
kpaxman commentedHere's my (possibly hacky) solution for this issue. I also reformatted spacing in the file.
Comment #3
johnvThanks for this.
I found 2 flaws:
- when revisiting the widget, an already filled in line, is hidden. Only if you press the 'add more hours' link, the line is shown. Data is not lost.
- when checking 'Validate hours' the entered values are not validated.
Comment #5
johnvI've committed kpaxman's patch, along with som others, which were not related to the javaScript:
- show 2nd, 3rd block if it has a value;
- align the label 'and' to the right, for better visibility.
For validating the contents, see #1965948: Handle the exceptional values in office_hours_feeds_set_target()
Comment #6
johnv