Part of #1945406: [meta] Convert all of confirm_form() to ConfirmFormBase

CommentFileSizeAuthor
#5 shortcut-1945564-5.patch18.75 KBtim.plunkett
#5 interdiff.txt4.18 KBtim.plunkett
#3 shortcut-1945564-3.patch15.67 KBtim.plunkett
#3 interdiff.txt881 bytestim.plunkett
#1 shortcut-1945564-1.patch15.91 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new shortcut-1945564-1.patch15.91 KB

Okay, here's a conversion. However, it seems that _menu_link_translate() completely skips the applies() method of access checkers, and calls access() blindly. I'll have to check in with Crell on that.

Oh yeah, and all the breadcrumbs/active trail are screwed up.

Status: Needs review » Needs work

The last submitted patch, shortcut-1945564-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt881 bytes
new shortcut-1945564-3.patch15.67 KB

Whoops, shouldn't have outright removed shortcut_link_access().

Status: Needs review » Needs work

The last submitted patch, shortcut-1945564-3.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt4.18 KB
new shortcut-1945564-5.patch18.75 KB

Okay, switched to an access controller.
We should scheme up a more generic one of those for entities.

Status: Needs review » Needs work
Issue tags: -FormInterface

The last submitted patch, shortcut-1945564-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
Issue tags: +FormInterface

#5: shortcut-1945564-5.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Postponed

Blocked by #1947432: Add a generic EntityAccessCheck to replace entity_page_access()

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

This conversion is probably going to go in as part of #1947432: Add a generic EntityAccessCheck to replace entity_page_access(). Stay tuned.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Postponed » Fixed

It is fixed as per #9 and #1947432-57: Add a generic EntityAccessCheck to replace entity_page_access().

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Fixed » Closed (duplicate)

Ah, yes.