Mosaicflow [#1945576]

This is my first module, I tried to keep it simple but useful for this version. Coder said it's all ok.

http://drupal.org/sandbox/fbeaudet/1945474
git clone http://git.drupal.org/sandbox/fbeaudet/1945474.git mosaicflow

Thanks reviewers !

Comments

Comment #1

ycshen commented 18 March 2013 at 05:10

Status:

Needs review

» Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

README.txt is missing, see the guidelines for in-project documentation.
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.


FILE: /var/www/drupal-7-pareview/pareview_temp/css/mosaicflow.css
--------------------------------------------------------------------------------
FOUND 73 ERROR(S) AFFECTING 27 LINE(S)
--------------------------------------------------------------------------------
  2 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
  2 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  2 | ERROR | Expected 1 space after colon in style definition; 0 found
  3 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
  3 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  3 | ERROR | Expected 1 space after colon in style definition; 0 found
  6 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
  6 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  6 | ERROR | Expected 1 space after colon in style definition; 0 found
  9 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
  9 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  9 | ERROR | Expected 1 space after colon in style definition; 0 found
 13 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 13 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 13 | ERROR | Expected 1 space after colon in style definition; 0 found
 16 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 16 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 16 | ERROR | Expected 1 space after colon in style definition; 0 found
 17 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 17 | ERROR | Expected 1 space after colon in style definition; 0 found
 18 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 18 | ERROR | Expected 1 space after colon in style definition; 0 found
 19 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 19 | ERROR | Expected 1 space after colon in style definition; 0 found
 22 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 22 | ERROR | Expected 1 space after colon in style definition; 0 found
 23 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 23 | ERROR | Expected 1 space after colon in style definition; 0 found
 24 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 24 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 24 | ERROR | Expected 1 space after colon in style definition; 0 found
 25 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 25 | ERROR | Expected 1 space after colon in style definition; 0 found
 26 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 26 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 26 | ERROR | Expected 1 space after colon in style definition; 0 found
 27 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 27 | ERROR | Expected 1 space after colon in style definition; 0 found
 28 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 28 | ERROR | Expected 1 space after colon in style definition; 0 found
 29 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 29 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 29 | ERROR | Expected 1 space after colon in style definition; 0 found
 30 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 30 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 30 | ERROR | Expected 1 space after colon in style definition; 0 found
 31 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 31 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 31 | ERROR | Expected 1 space after colon in style definition; 0 found
 32 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 32 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 32 | ERROR | Expected 1 space after colon in style definition; 0 found
 33 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 33 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 34 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
 34 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 35 | ERROR | Line indented incorrectly; expected 2 spaces, found 6
 35 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 36 | ERROR | Line indented incorrectly; expected 2 spaces, found 9
 36 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 39 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
 39 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 39 | ERROR | Expected 1 space after colon in style definition; 0 found
 40 | ERROR | Additional whitespace found at end of file
 41 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...-7-pareview/pareview_temp/jquery.mosaicflow-master/jquery.mosaicflow.js
--------------------------------------------------------------------------------
FOUND 119 ERROR(S) AFFECTING 117 LINE(S)
--------------------------------------------------------------------------------
  14 | ERROR | Comments may not appear after statements.
  15 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  16 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  24 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  29 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  30 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  32 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  33 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  34 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  35 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  36 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  39 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  40 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  42 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  43 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  45 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  48 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  51 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  52 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  54 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  55 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  56 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  57 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  58 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  60 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  61 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  62 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  63 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  65 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  66 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  67 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  68 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  69 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  70 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  71 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  72 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  73 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  74 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  75 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  76 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  77 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  78 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  79 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  80 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  81 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  82 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  83 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  84 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  85 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  86 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  87 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  88 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  89 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  90 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  91 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  93 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  94 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  95 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  96 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  97 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  98 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  99 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 100 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 101 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 102 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 103 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 105 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 106 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 107 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 108 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 109 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 111 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 113 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 114 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 116 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 117 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 118 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 119 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 120 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 120 | ERROR | Inline control structures are not allowed
 122 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 123 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 124 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 125 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 126 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 127 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 127 | ERROR | Inline control structures are not allowed
 129 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 130 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 131 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 132 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 133 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 134 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 136 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 137 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 138 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 139 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 140 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 141 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 142 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 143 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 144 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 145 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 146 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 147 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 149 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 150 | ERROR | Spaces must be used to indent lines; tabs are not allowed
--------------------------------------------------------------------------------


FILE: ...areview/pareview_temp/jquery.mosaicflow-master/jquery.mosaicflow.min.js
--------------------------------------------------------------------------------
FOUND 133 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 2 | ERROR | Expected 1 space before "=="; 0 found
 2 | ERROR | Expected 1 space after "=="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Inline control structures are not allowed
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "/"; 0 found
 2 | ERROR | Expected 1 space after "/"; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Inline control structures are not allowed
 2 | ERROR | Expected 1 space before ">"; 0 found
 2 | ERROR | Expected 1 space after ">"; 0 found
 2 | ERROR | Expected 1 space after first semicolon of FOR loop; 0 found
 2 | ERROR | Expected 1 space after second semicolon of FOR loop; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "-"; 0 found
 2 | ERROR | Expected 1 space after "-"; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before ">"; 0 found
 2 | ERROR | Expected 1 space after ">"; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Inline control structures are not allowed
 2 | ERROR | Expected 1 space before ">"; 0 found
 2 | ERROR | Expected 1 space after ">"; 0 found
 2 | ERROR | Inline control structures are not allowed
 2 | ERROR | Expected 1 space after first semicolon of FOR loop; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before ">="; 0 found
 2 | ERROR | Expected 1 space after ">="; 0 found
 2 | ERROR | Expected 1 space before "!=="; 0 found
 2 | ERROR | Expected 1 space after "!=="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "+"; 0 found
 2 | ERROR | Expected 1 space after "+"; 0 found
 2 | ERROR | Expected 1 space before "/"; 0 found
 2 | ERROR | Expected 1 space after "/"; 0 found
 2 | ERROR | Expected 1 space before "+"; 0 found
 2 | ERROR | Expected 1 space after "+"; 0 found
 2 | ERROR | Expected 1 space after first semicolon of FOR loop; 0 found
 2 | ERROR | Expected 1 space after second semicolon of FOR loop; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before ">"; 0 found
 2 | ERROR | Expected 1 space after ">"; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space after first semicolon of FOR loop; 0 found
 2 | ERROR | Expected 1 space after second semicolon of FOR loop; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before ">"; 0 found
 2 | ERROR | Expected 1 space after ">"; 0 found
 2 | ERROR | Expected 1 space before "+="; 0 found
 2 | ERROR | Expected 1 space after "+="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "+="; 0 found
 2 | ERROR | Expected 1 space after "+="; 0 found
 2 | ERROR | Expected 1 space after first semicolon of FOR loop; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Inline control structures are not allowed
 2 | ERROR | Expected 1 space before "==="; 0 found
 2 | ERROR | Expected 1 space after "==="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "="; 0 found
 2 | ERROR | Expected 1 space after "="; 0 found
 2 | ERROR | Expected 1 space before "+"; 0 found
 2 | ERROR | Expected 1 space after "+"; 0 found
 2 | ERROR | Inline control structures are not allowed
 2 | ERROR | Expected 1 space before ">="; 0 found
 2 | ERROR | Expected 1 space after ">="; 0 found
 2 | ERROR | Expected 1 space before "-="; 0 found
 2 | ERROR | Expected 1 space after "-="; 0 found
 2 | ERROR | Expected 1 space before "+="; 0 found
 2 | ERROR | Expected 1 space after "+="; 0 found
 2 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/mosaicflow.info
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
  1 | ERROR | It's only necessary to declare files[] if they declare a class or
    |       | interface.
  7 | ERROR | It's only necessary to declare files[] if they declare a class or
    |       | interface.
  9 | ERROR | It's only necessary to declare files[] if they declare a class or
    |       | interface.
 10 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/mosaicflow.module
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
  7 | ERROR | Missing function doc comment
 16 | ERROR | Missing function doc comment
 17 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
 18 | ERROR | Array indentation error, expected 6 spaces but found 4
 19 | ERROR | Array closing indentation error, expected 4 spaces but found 2
 20 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/theme/mosaicflow.theme.inc
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
  2 | ERROR | Missing file doc comment
  2 | ERROR | Missing short description in function doc comment
  3 | ERROR | Expected 1 space(s) before asterisk; 0 found
  4 | ERROR | Expected 1 space(s) before asterisk; 0 found
  5 | ERROR | Expected 1 space(s) before asterisk; 0 found
 10 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------


FILE: /var/www/drupal-7-pareview/pareview_temp/theme/mosaicflow.tpl.php
--------------------------------------------------------------------------------
FOUND 12 ERROR(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
 16 | ERROR | Language constructs must be followed by a single space; expected
    |       | "print (" but found "print("
 16 | ERROR | Concat operator must be surrounded by spaces
 16 | ERROR | Concat operator must be surrounded by spaces
 18 | ERROR | The control statement should use the ":" alternative syntax
    |       | instead of curly braces in template files
 21 | ERROR | Language constructs must be followed by a single space; expected
    |       | "print (" but found "print("
 22 | ERROR | Language constructs must be followed by a single space; expected
    |       | "print (" but found "print("
 22 | ERROR | Concat operator must be surrounded by spaces
 22 | ERROR | Concat operator must be surrounded by spaces
 22 | ERROR | Concat operator must be surrounded by spaces
 23 | ERROR | Language constructs must be followed by a single space; expected
    |       | "print (" but found "print("
 26 | ERROR | Language constructs must be followed by a single space; expected
    |       | "print (" but found "print("
 28 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...r/www/drupal-7-pareview/pareview_temp/views_plugin_style_mosaicflow.inc
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
 13 | ERROR | Class name must begin with a capital letter
 13 | ERROR | Class name must use UpperCamel naming without underscores
 15 | ERROR | Function comment short description must end with a full stop
 17 | ERROR | Method name "views_plugin_style_mosaicflow::option_definition" is
    |       | not in lowerCamel format, it must not contain underscores
 17 | ERROR | No scope modifier specified for function "option_definition"
 27 | ERROR | Method name "views_plugin_style_mosaicflow::options_form" is not
    |       | in lowerCamel format, it must not contain underscores
 27 | ERROR | No scope modifier specified for function "options_form"
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

Comment #2

fbeaudet commented 18 March 2013 at 05:14

Lol ! ok, yeah needs work.

Comment #3

fbeaudet commented 20 March 2013 at 02:29

Status:

Needs work

» Needs review

SO ! I learned a lot, I fixed every single error PAReview.sh gaved me. I also had to get the jquery lib out for license problem.

http://ventral.org/pareview/httpgitdrupalorgsandboxfbeaudet1945474git
http://git.drupal.org/sandbox/fbeaudet/1945474.git

Comment #4

likebtn commented 24 March 2013 at 12:49

1) Module required Views and Ctools modules. What about mentioning it on the project page, README.txt and in mosaicflow.info:
dependencies[] = views
dependencies[] = ctools

2) In mosaicflow.module:

function mosaicflow_init() {

  $vs_path = drupal_get_path('module', 'mosaicflow');
  drupal_add_js($vs_path . '/jquery.mosaicflow/jquery.mosaicflow.min.js');
  drupal_add_css($vs_path . '/css/mosaicflow.css');
}

After cloning repo I have /mosaicflow/css/mosaicflow.css, but I don't have /mosaicflow/jquery.mosaicflow/jquery.mosaicflow.min.js

3) Consider justifying tabs and indent in order to keep code well formatted. For example, in mosaicflow.views.inc:

  return array(
    'style' => array(
      'mosaicflow' => array(
        'title' => t('jQuery.Mosaicflow'),
        'handler' => 'ViewsPluginStyleMosaicflow',
        'type' => 'normal',
        'uses row plugin' => TRUE,
        'uses fields' => TRUE,
        'uses options' => TRUE,
        'path' => drupal_get_path('module', 'mosaicflow'),
        'theme' => 'mosaicflow',
        'theme path' => drupal_get_path('module', 'mosaicflow') . '/theme',
        'theme file' => 'mosaicflow.theme.inc',
      ),
    ),
  );

replace with:

  return array(
    'style' => array(
      'mosaicflow' => array(
        'title'           => t('jQuery.Mosaicflow'),
        'handler'         => 'ViewsPluginStyleMosaicflow',
        'type'            => 'normal',
        'uses row plugin' => TRUE,
        'uses fields'     => TRUE,
        'uses options'    => TRUE,
        'path'            => drupal_get_path('module', 'mosaicflow'),
        'theme'           => 'mosaicflow',
        'theme path'      => drupal_get_path('module', 'mosaicflow') . '/theme',
        'theme file'      => 'mosaicflow.theme.inc',
      ),
    ),
  );

Comment #5

luco commented 26 March 2013 at 03:29

hi @fbeaudet,

beautiful module! I love it.

however, if you install it without the library, it won't display any warnings. you should check for the library and warn users.

the way it works is kinda constrained: you have to have a title first and then an image... it should be more flexible than that. maybe allowing for text boxes instead of images?

and I got the following message:
Notice: Undefined index: class in include() (line 16 of /yadayada/sites/all/modules/custom/mosaicflow/theme/mosaicflow.tpl.php).

cheers,
Luciano

Comment #6

arnoldbird commented 2 April 2013 at 17:59

@fbeaudet,

Thanks for your submission.

Manual review:

In your README.txt, you ask the user to download a jquery plugin to your module. Instead, you should use the Libraries API to provide the jquery plugin: http://drupal.org/project/libraries

There are some problems with your mosaicflow.tpl.php file. You need to use check_plain() each of the three times you print variables: $options['class'], $item[1] and $item[0]. Also, in a template it's typical to use fewer print() calls and instead present more of the HTML output outside of PHP tags, like so...

<?php foreach($view->style_plugin->rendered_fields as $item):
$item = array_values($item); ?>
    <div class="mosaicflow__item">
    <?php print check_plain($item[1]); ?>
    <p><?php print check_plain($item[0]); ?></p>
    </div>
<?php endforeach; ?>

In classes, dashes are usually preferred to underscores. That is, 'mosaicflow-item' instead of 'mosaicflow__item'.

I have not looked at a lot of views plugins, but I wonder if it's typical to use the module's machine name as the theme function name, as you've done in mosaicflow.theme.inc. It seems odd to see a function whose entire name is the same as the module name. Also, your comments in that file indicate that this is a preprocess function, but I don't think that's correct. In Drupal, preprocess functions are typically functions that actually have "preprocess" in the name of the function. For example, hook_page_preprocess(). It looks like (based on this and this) a more typical name for the theme function would be views_view_mosaicflow(), and this would not be considered a preprocess function.

The name of your class seems non-standard. You have...

class ViewsPluginStyleMosaicflow extends views_plugin_style

...when I think the norm is...

class views_plugin_mosaicflow extends views_plugin_style

Of course, the camelCase approach will work, but I think you should follow the example of the class you are extending.

As suggested earlier in the thread, you should add the ctools dependency in your info file:
dependencies[] = ctools

Comment #7

arnoldbird commented 2 April 2013 at 17:59

Status:

Needs review

» Needs work

Changing to "needs work" based on my manual review above.

Comment #8

arnoldbird commented 2 April 2013 at 18:48

You need to use check_plain() each of the three times you print variables: $options['class'], $item[1] and $item[0]

I'm actually not sure about this. It may be that the variables are safe enough given where they are coming from? Sorry I can't be more decisive about this. I'm having trouble finding examples of views plugins.

Comment #9

arnoldbird commented 3 April 2013 at 01:00

This looks to be a good example of a module that implements a jquery plugin as a library: http://drupal.org/project/equalheights

Comment #10

PA robot commented 12 June 2013 at 04:25

Status:

Needs work

» Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Mosaicflow

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

News items

Our community

Documentation

Drupal code base

Governance of community