function elysia_cron_set_channel_last_abort_function($channel, <strong>$job</strong>) {
  return elysia_cron_set($channel, TRUE, array('last_abort_function' => <strong>$v)</strong>);
}

The code above (line 513, 514 and 515 of elysia_cron.module version 7.x-2.1), seems to be incorrect, as $v doesn't exist in this function scope, shouldn't it be $job instead?

Comments

bpresles’s picture

bpresles commented

Sorry for the <strong></strong> tags in above comment. I wanted to highlight $v and $job variable to highlight the mismatch, but inside <code></code> it doesn't seem to be possible.

I paste again the code below for readability purpose:

function elysia_cron_set_channel_last_abort_function($channel, $job) {
  return elysia_cron_set($channel, TRUE, array('last_abort_function' => $v));
}
gotheric’s picture

gotheric commented
Status: Active » Needs work

You are right, this should be:

function elysia_cron_set_channel_last_abort_function($channel, $job) {
  return elysia_cron_set($channel, TRUE, array('last_abort_function' => $job));
}

Probably this has broken in one of the last refactorings...

I'll commit the fix soon, thanks

gotheric’s picture

gotheric commented
Assigned: Unassigned » gotheric
Status: Needs work » Fixed

Committed in dev version

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.