I should be able to fix these myself, but others may not be able to. Here's my first impressions.

I was using Mandrill 1.3, and just upgraded to 1.4.

I removed mandrill 1.3, and extracted 1.4. I ran `drush updatedb -y` to upgrade the database. Then I clicked on the mandrill tab in my admin menu.

The page never loads.

Looking through the code, I noticed there's a new module called Mandrill Template. I enabled this module via the admin and I receive this error.

DatabaseSchemaObjectExistsException: Table <em class="placeholder">mandrill_template_map</em> already exists. in DatabaseSchema->createTable() (line 657 of includes/database/schema.inc).

I assume this is because this table already existed from 1.3 and it now attempting to get created via the new module. We should test and see if it exists, and if it does, not create it (or alter it to it's new format if it's changed).

Noticed this is in the release notes, but it's kinda sloppy.

PLEASE NOTE IF YOU ARE UPGRADING FROM 7.x-1.3:

You will see the following error message when enabling the mandrill_template module:

DatabaseSchemaObjectExistsException:
Table mandrill_template_map already exists.

Module was enabled though, so I move on and go visit the template page. I click on "edit" for my previous template and I get this error.

Notice: Undefined index: mandrill_template_map_form in drupal_retrieve_form() (line 763 of includes/form.inc).
Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'mandrill_template_map_form' not found or invalid function name in drupal_retrieve_form() (line 798 of includes/form.inc).

Clearing the caches resolved that problem.

Comments

j0rd’s picture

j0rd commented

With that said, it appears everything else seems to be chugging along and working.

Thanks for implementing some of my suggestions / fixes.

For those who are interested, here's a generic hook_mandrill_mail_alter() hook which you can use to get subject, from, to and domain merge variables into your template. It also adds all first level strings which you've passed via drupal_mail's $params into merge variables.

IMHO, these global merge vars (from, subject, domain) should be passed by default. Also to merge vars.

Any others could be added via the hook...but these are pretty standard and could help people out and add minimal overhead.


function YOURMODULE_mandrill_mail_alter(&$mandrill_params, $message) {
  $global_merge_vars = array();
  $global_merge_vars[] = array(
    'name' => 'subject',
    'content' => $message['subject'],
  );
  $global_merge_vars[] = array(
    'name' => 'from',
    'content' => $message['from'],
  );
  $global_merge_vars[] = array(
    'name' => 'domain',
    'content' => $GLOBALS['base_url'] . $GLOBALS['base_path'],
  );

  if(!empty($message['params'])) {
    foreach($message['params'] as $name => $content) {
      if(is_string($content)) {
        $global_merge_vars[] = array(
          'name' => $name,
          'content' => $content,
        );
      }
    }
  }

  $merge_vars = array();
  if(!empty($mandrill_params['message']['to'])) {
    foreach($mandrill_params['message']['to'] as $i => $rcpt) {
      $vars = array();
      $vars[] = array(
        'name' => 'to',
        'content' => $rcpt['email'],
      );
      $merge_vars[] = array(
        'rcpt' => $rcpt['email'],
        'vars' => $vars,
      );
    }
  }

  $mandrill_params['message']['global_merge_vars'] = $global_merge_vars;

  if(!empty($merge_vars)) {
    $mandrill_params['message']['merge_vars'] = $merge_vars;
  }
}
j0rd’s picture

j0rd commented
Issue summary: View changes

Added info about clearing the caches.