Hi,
this is some general feedback on the available documentation.

From #1778566-2: Commerce Shipping 2.0 Plugin Upgrade Path

plugins have been dropped completely

This is not very obvious from looking at the module page.
Also, the "release notes" link on the module page just links to the module page itself.

I suggest to start any documentation with a "big picture":
- 7.x-1.x was all about plugins
- In 7.x-2.x you can use either rules, or a custom module with hook_commerce_shipping_method_info(), hook_commerce_shipping_service_info(), and shipping rate callback.

Personally I much prefer custom modules to clicking around in rules.
http://www.drupalcommerce.org/user-guide/calculating-flat-rate-based-cus...
that's a lot of clicking :)
It would be great to have an equivalent of this guide using a custom rate callback.

Comments

donquixote’s picture

donquixote commented

I should add, the commerce_shipping_example module in 2.x already shows a lot of stuff.

What it doesn't say is how to get the shipping address, based on which I want to calculate the rate.
I ended up with this:

function _mymodule_shipping_address($order) {
  // field_get_items() feels awkward.
  foreach (field_get_items('commerce_order', $order, 'commerce_customer_shipping') as $profile_item) {
    $profile = commerce_customer_profile_load($profile_item['profile_id']);
    if ($profile) {
      foreach (field_get_items('commerce_customer_profile', $profile, 'commerce_customer_address') as $address) {
        return $address;
      }
    }
  }
}

Ok, I hope this issue is somewhat useful in improving the docs.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

To add to this, in the upgrade instructions, it doesn't mention that one can delete his or her "plugins" directory. Is this in fact the case?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Active » Needs review

I just ran through the process with some dd() calls, and confirmed that the plug-in implementation is no longer required in 2.x. It should be removed in favour of the hook implementation. The example module folder's plugin-in implementation was removed to reflect this, but I was using a pre-2.0 dev release which didn't have that commit yet.

@donquixote: Do you think the up-to-date example module is sufficient, or is further documentation necessary?

googletorp’s picture

googletorp commented
Issue summary: View changes
Status: Needs review » Fixed

Think this is done, otherwise you can reopen.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.