On some pages, Menu Minipanels triggers a JS error. This happens because the JS code is included, but there might not be a Panel on the page.

This patch verifies the Drupal.settings.menuMinipanels property actually exists before executing the code.

CommentFileSizeAuthor
#5 menu_minipanels-n1947590-3.patch550 bytesdamienmckenna
#4 menu_minipanels-n1947590-4.patch536 bytesdamienmckenna
#3 menu_minipanels-n1947590-3.patch550 bytesdamienmckenna
menu_minipanels.js_.patch541 byteswadmiraal

Comments

tswaters’s picture

tswaters commented

I'm getting this as well

This crops up in our environment on administrative pages that do not include minipanels (node add forms) and breaks certain functionalities that require javascript -- we use media browser plus and this js error is causing all sorts of things to fail.

Applying the patch makes the problems go away.

alexkb’s picture

alexkb commented

For those that have their mega mini panels disabled in IE7, this patch is also helpful for fixing a very similar JS error. Thanks wadmiraal!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
StatusFileSize
new menu_minipanels-n1947590-3.patch550 bytes

I believe this is how it should be done.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
StatusFileSize
new menu_minipanels-n1947590-4.patch536 bytes

D6 backport.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new menu_minipanels-n1947590-3.patch550 bytes

Weird, it queued the D7 branch against the 6.x branch. Lets try this again.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks wadmiraal!

The last submitted patch, 3: menu_minipanels-n1947590-3.patch, failed testing.

The last submitted patch, 4: menu_minipanels-n1947590-4.patch, failed testing.

wadmiraal’s picture

wadmiraal commented

Glad I could help :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.