Extra field renderer is completely broken [#1947680]

ctools_entity_field_extra_content_type_render() tries to get extra field content by using hooks (hook_entity_view and hook_ENTITYTYPE_view). This works great if extra fields are added by additional modules, but if the extra field is defined in the entity module itself and is rendered in entity module _view functon, this fails. The real example is taxonomy term description field. It can't be shown by current ctools. The provided patch tries to solve this problem, but more general solution is welcomed.

Comment	File	Size	Author
#1	extra_field_renderer-1947680-1.patch	1.5 KB	maximpodorov
	extra_field_renderer.patch	1.52 KB	maximpodorov

Comments

Comment #1

maximpodorov commented 20 March 2013 at 11:21

Status	File	Size
new	extra_field_renderer-1947680-1.patch	1.5 KB

Updated patch. $langcode was in the wrong place.

Comment #2

andypost

he/him

Russian

commented 3 June 2013 at 12:03

+++ b/plugins/content_types/entity_context/entity_field_extra.incundefined
@@ -97,13 +97,20 @@ function ctools_entity_field_extra_content_type_render($subtype, $conf, $panel_a
+  $function = $entity_type . '_view';
+  if (in_array($entity_type, array('node', 'taxonomy_term', 'user')) && function_exists($function)) {
+    // Call known ENTITY_view() to get the extra field.
+    $entity->content = $function($entity, $conf['view_mode'], $langcode);
+  }
+  else {
...
+    module_invoke_all($entity_type . '_view', $entity, $conf['view_mode'], $langcode);

this needs elsif for comment_view() which have different signature

Comment #3

maximpodorov commented 3 June 2013 at 14:36

What extra fields defined in comment module are subjects of this issue?

Comment #4

andypost

he/him

Russian

commented 3 June 2013 at 15:00

Author and subject @see comment_field_extra_fields()

Issue summary:	View changes
Status:	Needs review	» Reviewed & tested by the community

Reviewed and tested against 7.x-1.x-dev.

Comment #8

jody lynn

she/her

English

commented 11 November 2013 at 22:33

Duplicate of #1907800: Extra fields need the fully built entity

Comment #9

andypost

he/him

Russian

commented 15 November 2013 at 23:50

The approach in #1907800: Extra fields need the fully built entity is different that does not care about specific implementations, so I'd like current issue way