Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
The problem is if you just install the extension I can not guarantee that all the tests will pass without that patch as our current implementation is just broken - which is why we need to have the extension on testbot ... so we can test it :)
And by 'current implementation is broken', you're referring to code that already exists in HEAD, correct? (i.e. HEAD could start failing once the extension is added?)
I've installed the php5-intl package on drupaltestbot-dev-mysql.osuosl.test, and am currently running through a full D8 HEAD test to ensure it still passes.
Note: I simply installed php5-intl using apt, rather than installing the PECL extension ... apparently intl has been included in PHP since 5.3, and the PECL extension simply backports improvements from the -dev stream (based on http://pecl.php.net/package/intl) ... If we can do without the backports, that may make it easier to add this to the puppet install.
Comments
Comment #1
rfayIt seems that #9 in #1944636-9: PECL Intl extension usage in DateTimePlus class broken and untested expresses specific reservations about the use of this extension. I'd appreciate more elaboration about that.
Comment #2
alexpott@rfay #1944636-9: PECL Intl extension usage in DateTimePlus class broken and untested express reservations around the implementation in Drupal not the pecl extension itself... once the extension is installed and that patch committed everything works great.
The problem is if you just install the extension I can not guarantee that all the tests will pass without that patch as our current implementation is just broken - which is why we need to have the extension on testbot ... so we can test it :)
Comment #3
jthorson commentedAnd by 'current implementation is broken', you're referring to code that already exists in HEAD, correct? (i.e. HEAD could start failing once the extension is added?)
Comment #4
jthorson commentedI've installed the php5-intl package on drupaltestbot-dev-mysql.osuosl.test, and am currently running through a full D8 HEAD test to ensure it still passes.
I'll then run the patch in http://drupal.org/node/1944636#comment-7189972 through, to verify it passes with the package installed.
Note: I simply installed php5-intl using apt, rather than installing the PECL extension ... apparently intl has been included in PHP since 5.3, and the PECL extension simply backports improvements from the -dev stream (based on http://pecl.php.net/package/intl) ... If we can do without the backports, that may make it easier to add this to the puppet install.
Comment #5
jthorson commentedD8 Head passed ... now testing the second patch. If it passes, we can deploy this to all bots.
Edit: http://qa.staging.devdrupal.org/pifr/test/178658 is the second test.
Comment #6
rfayCommitted in http://drupalcode.org/project/drupaltestbot-puppet.git/commitdiff/05d37a0
Had we known this was just the regular php5-intl package we probably would have had it out there a long time ago :-)
Comment #7
rfayDeployed on all of the testbots.