Currently the $enable_dependencies is set to FALSE. But this leads to problems. Some examples

Following drush log is given:
The following will be enabled: commerce_discount, number, entityreference, ds, link, email, date, field_group, linkit, pm_existing_pages, [success]
page_manager, panels, devel, toolbar, commerce_coupon, configuration_ui, ife, locale, mailsystem, menu_attributes, menu_position, message, module_filter, nodequeue,
pathauto, path, token, commerce_backoffice_product, commerce_product_pricing_ui, commerce_tax_ui, commerce_tax, ds_ui, mimemail, l10n_client, i18n_string, i18n, variable,
translation, views_content

Conflicting modules:

- commerce discount module: This module has an install hook that creates new entity reference fields. But entityreference module is enabled lower in the list.
This leads to following error:
WD php: FieldException: Attempt to create a field of unknown type entityreference. in field_create_field() (line 110 of [error]
/Users/zuuperman/Documents/workspace/westtoer-webshop/www/modules/field/field.crud.inc).
FieldException: Attempt to create a field of unknown type entityreference. in field_create_field() (line 110 of /Users/zuuperman/Documents/workspace/westtoer-webshop/www/modules/field/field.crud.inc).

- commerce_tax_ui: This module has a call to commerce_tax_types_reset (from commerce_tax_ui). Commerce tax is also enabled lower in the list.
This leads to following error:
Fatal error: Call to undefined function commerce_tax_types_reset() in /Users/zuuperman/Documents/workspace/westtoer-webshop/www/profiles/commerce_kickstart/modules/contrib/commerce/modules/tax/commerce_tax_ui.module on line 289

Changing module_enable($modules_to_install, FALSE); into module_enable($modules_to_install, TRUE); fixes the problems

Comments

nils.destoop’s picture

StatusFileSize
new1.41 KB

Patch attached

nils.destoop’s picture

Status: Active » Needs review
bojanz’s picture

Status: Needs review » Reviewed & tested by the community

I believe this always makes sense.

dagmar’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.