Since we currently don't display one. This link is provided by og_ui.module, which is disabled in Commons.

CommentFileSizeAuthor
#11 1948224-commons_groups-request_membership_link-11.patch15.99 KBitamar
#10 1948224-10-commons_groups-request_membership_link.patch15.97 KBezra-g
#9 1948224-9-commons_groups-request_membership_link.patch9.55 KBitamar
#9 1948224-9-commons_origins-request_membership_link.patch9.75 KBitamar
#9 inivitation.png51.14 KBitamar
#9 moderated.png41.25 KBitamar
#9 public.png29.1 KBitamar
#9 user_groups.png63.66 KBitamar
#2 1948224-og_membership_link-2.diff1.2 KBitamar
#2 membership-link.png81.04 KBitamar
#3 membership-link.png85.54 KBitamar
#3 membership-link2.png81.08 KBitamar
#3 1948224-og_membershop_link-3.patch2.3 KBitamar
#1 Screenshot_4_4_13_7_07_AM-3.png37.67 KBezra-g
#1 Screenshot_4_4_13_7_09_AM-2.png109.99 KBezra-g

Comments

ezra-g’s picture

ezra-g commented
Issue tags: +gizra commons
StatusFileSize
new Screenshot_4_4_13_7_09_AM-2.png109.99 KB
new Screenshot_4_4_13_7_07_AM-3.png37.67 KB

Attached are 2 screenshots showing where these links would appear in the UI.

itamar’s picture

itamar commented
StatusFileSize
new membership-link.png81.04 KB
new 1948224-og_membership_link-2.diff1.2 KB

Ignore this comment

itamar’s picture

itamar commented
StatusFileSize
new 1948224-og_membershop_link-3.patch2.3 KB
new membership-link2.png81.08 KB
new membership-link.png85.54 KB

Displaying the membership link on group nodes.

membership-link.png

membership-link2.png

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Active » Needs review

Correct status

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

@itamar, let's add the needed CSS so it looks like the images in #1

WebSinPat’s picture

WebSinPat commented

I have applied the patch, and still do not see such a link.
i suspect it's tied in to some of the other issues floating around the queue about private groups and the default of non members being allowed to post to public groups. if anyone can tell me how to set up the configuration so that membership must be requested rather than automatically granted by posting to a group, i'd appreciate it.

ezra-g’s picture

ezra-g commented
Status: Needs review » Needs work

I tested and confirmed that after reverting Commons Groups and doing a drush cc all, the links work as expected with the 3 major group types (open, moderated, invite only).

However, the language and placement doesn't algin with some earlier designs we produced. It's entirely my fault that the review here is delayed and the designs weren't presented along with this issue, so if you prefer, I'll re-roll or have another Commons team member re-roll:

The designs and invite link text can be viewed at:

#1782658: Support for moderated, closed & private groups.

ezra-g’s picture

ezra-g commented

Eg, Unsubscribe from group should be "Leave group" to avoid confusion with Following.

itamar’s picture

itamar commented
Status: Needs work » Needs review
StatusFileSize
new user_groups.png63.66 KB
new public.png29.1 KB
new moderated.png41.25 KB
new inivitation.png51.14 KB
new 1948224-9-commons_origins-request_membership_link.patch9.75 KB
new 1948224-9-commons_groups-request_membership_link.patch9.55 KB

Adding a custom formatter for the group field.

inivitation.png

moderated.png

public.png

user_groups.png

ezra-g’s picture

ezra-g commented
Status: Needs review » Needs work
StatusFileSize
new 1948224-10-commons_groups-request_membership_link.patch15.97 KB

Looking close - Thanks.

A) No changes took effect for upgrading sites. I added an upgrade path.

B) No join links appeared in node teasers. I added the group_group field with the proper formater to the Panelizer config for group nodes and an upgrade path for that.

C) We shouldn't ever display a "join" link on public groups.

itamar’s picture

itamar commented
StatusFileSize
new 1948224-commons_groups-request_membership_link-11.patch15.99 KB

I fixed C and cleaned up the patch a little.

itamar’s picture

itamar commented
Status: Needs work » Needs review

Updating status.

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Looks good. Thanks, itamar!

http://drupalcode.org/project/commons_groups.git/commit/b648c23

Automatically closed -- issue fixed for 2 weeks with no activity.