Google Analytics 8 upgrade

#1903586: Create Drupal8 Branch

Reopening this case as the title fits best and the case has a patch.

This will fail...

Work in process, does not contain changes from #1 and produces

Error message

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "drupal\google_analytics\google_analyticssettingsform". in Symfony\Component\DependencyInjection\Container->get() (line 279 of core\vendor\symfony\dependency-injection\Symfony\Component\DependencyInjection\Container.php).
The website has encountered an error. Please try again later.

No idea what's wrong, just sharing my latest code. Ideas welcome!

Latest patch. Needs help! #1962876: Misleading error message: Symfony ServiceNotFoundException: You have requested a non-existent service

Issue #8 still exists, but stuff in hook_page_alter() works. Main issues are in the setting form.

Fixed variables in submitForm()

Current_path(), http://drupal.org/node/1888424#comment-7283326

Settings form works. Let's see how the tests are failing.

Upgraded tests files, a few tests are failing.

Committed latest code for now to remove form patch issue.

http://drupalcode.org/project/google_analytics.git/commit/7f993f0

A

A

A

Moved google_analytics.settings.last_cache to state system per #1775842: [meta] Convert all variables to state and/or config systems.

http://drupalcode.org/project/google_analytics.git/commit/b47f207
http://drupalcode.org/project/google_analytics.git/commit/a60a5a6

a

a

Attached is a patch which addresses a few small things i needed to get up and running.

This is not against latest DEV and seems to contain a lot of unnecessary changes.

the js variable name changes were because in chrome the Google_Analytics.* variables throw warnings.

Interresting... Why does it warn?

unexpected "." on the lines with the variables.

Than i guess every drupal.setting.* must throw the same warning, isn't it?

Well, yes and no. They probably would, but Drupal.settings. has been changed to "drupalSettings"

See https://drupal.org/node/1793334

But setting var still has dots...

Im not sure. All i know is that with the "." chrome threw js errors. Without them, chrome was happy.

Doing a little more digging, it looks like initializing the Google_Analytics object, and then just setting its properties instead of creating new variables works just fine.

Not against dev. Please refresh your clone.

I'd like to find out why drupal core can use dots in all function names...

JavaScript settings moved from Drupal.settings to global drupalSettings variable
Commit: http://drupalcode.org/project/google_analytics.git/commit/7cd1eb7

I guess I got it now. We could create the object like Drupal var Google_Analytics = Google_Analytics || {}; on the very top, but I decided to reuse the Drupal namespace as I've seen locale module also does with Drupal.locale.* and I guess it's allowed to jump into these Drupal namespace. This means all function names are Drupal.google_analytics.* from now. I also changed all regexes into it's own functions for easier reuse. I believe this is cleaner and looks better. It may be a bit more code, but I don't care about this.

This patch is completely untested and was only made code wise.

Causes warnings

Worked on the JS stuff and wrote a lot of tests and checked that everything really works as before. Have not found any issues yet.

Committed http://drupalcode.org/project/google_analytics.git/commit/1aa4a40

a

a

a

a

a

a

The remaining task seems not to happen in D8. Therefore closing now. However it's safe to say, D8 core may break the module again and we need to follow core than. But porting is done.