(Not a huge issue for those of us who understand views, but might help some newbies):
When creating a new view, if I am happy with the default settings from the "add view" page and click "Save and Edit", I am brought to a new screen, but there is nothing to suggest that I don't need to save the view in this new screen, or any button called "Save" just in case I do.
I looked around a bit, then decided to add "something" to "see what would happen" … then a "Save" button (and helpful notice came up on the screen).
Perhaps this helpful notice could display at all times:
if I don't need to save: "All changes have been saved"
if I do need to save: "Changes are stored temporarily …"
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | views_saved_message-1949032-16-complete.patch | 1.24 KB | geertvd |
Comments
Comment #1
dawehnerGood idea, it's indeed totally wrong to not show a message at all.
What about "View has been created", similar to the text provided by node module?
Comment #2
dawehner#1: drupal-1949032-1.patch queued for re-testing.
Comment #4
irfworld commentedSolved & Unit testing done.
Comment #5
irfworld commentedSolved & Unit testing done.
Comment #6
vaibhavjainWe see extra space here, please remove this. Rest looks good.
Comment #7
irfworld commented@vaibhanjain
Thanks for the review, the space has been removed.
Comment #8
irfworld commentedComment #9
chandru225 commentedReviewed and tested at #dcb2015.
Comment #10
dawehner+1 for the idea. I think we should have some automatic testing to ensure that the message is there.
This could be added to
\Drupal\views\Tests\Wizard\BasicTest::testViewsWizardAndListingComment #11
chandru225 commentedComment #12
RavindraSingh commented@chandru225, Issue is already tagged with needs tests. and you made it RTBC without any comments, which is not a good practice. please join #Drupal on IRC so we can guide you how to review.
Comment #13
irfworld commentedHye folks,
Please do some testing.....
Comment #14
RavindraSingh commented@irfworld,
Please add a tests for this message
Comment #15
markconroy commentedHi Guys,
Great to see this progressed this far. It's quite a nice UX coup for views in D8.
Thanks a lot.
Comment #16
geertvd commentedComment #18
olli commentedLooks good to me.
Comment #19
RavindraSingh commentedI can see this in tests now, Good work @geertvd, @irfworld and @olli
Patch #16 is ready to commit.
Keeping it RTBC
Comment #20
alexpottComment #21
alexpottAdding a helpful message to the UI is permitted in the beta evaluation since usability improvements are acceptable. Committed 8f9ece9 and pushed to 8.0.x. Thanks!