(Not a huge issue for those of us who understand views, but might help some newbies):

When creating a new view, if I am happy with the default settings from the "add view" page and click "Save and Edit", I am brought to a new screen, but there is nothing to suggest that I don't need to save the view in this new screen, or any button called "Save" just in case I do.

I looked around a bit, then decided to add "something" to "see what would happen" … then a "Save" button (and helpful notice came up on the screen).

Perhaps this helpful notice could display at all times:

if I don't need to save: "All changes have been saved"
if I do need to save: "Changes are stored temporarily …"

Comments

dawehner’s picture

Category: feature » task
Status: Active » Needs review
Issue tags: +VDC
StatusFileSize
new605 bytes

Good idea, it's indeed totally wrong to not show a message at all.

What about "View has been created", similar to the text provided by node module?

dawehner’s picture

Issue tags: -VDC

#1: drupal-1949032-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal-1949032-1.patch, failed testing.

irfworld’s picture

Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +SprintWeekend2015
StatusFileSize
new569 bytes

Solved & Unit testing done.

irfworld’s picture

StatusFileSize
new575 bytes

Solved & Unit testing done.

vaibhavjain’s picture

Status: Needs review » Needs work
+++ b/core/modules/views_ui/src/ViewAddForm.php
@@ -192,7 +192,8 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
+    ¶

We see extra space here, please remove this. Rest looks good.

irfworld’s picture

StatusFileSize
new569 bytes

@vaibhanjain
Thanks for the review, the space has been removed.

irfworld’s picture

Status: Needs work » Needs review
chandru225’s picture

Reviewed and tested at #dcb2015.

dawehner’s picture

Issue tags: +Needs tests

+1 for the idea. I think we should have some automatic testing to ensure that the message is there.
This could be added to \Drupal\views\Tests\Wizard\BasicTest::testViewsWizardAndListing

chandru225’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -SprintWeekend2015, -Needs tests +#DCB2015
RavindraSingh’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: -#DCB2015 +Needs tests

@chandru225, Issue is already tagged with needs tests. and you made it RTBC without any comments, which is not a good practice. please join #Drupal on IRC so we can guide you how to review.

irfworld’s picture

Hye folks,

Please do some testing.....

RavindraSingh’s picture

@irfworld,

+++ b/core/modules/views_ui/src/ViewAddForm.php
@@ -192,7 +192,7 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
+    drupal_set_message($this->t('The view %name has been saved.', array('%name' => $form_state->getValue('label'))));

Please add a tests for this message

markconroy’s picture

Hi Guys,

Great to see this progressed this far. It's quite a nice UX coup for views in D8.

Thanks a lot.

geertvd’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new702 bytes
new1.24 KB

The last submitted patch, 16: views_saved_message-1949032-16-test.patch, failed testing.

olli’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new7.06 KB

Looks good to me.

RavindraSingh’s picture

+++ b/core/modules/views/src/Tests/Wizard/BasicTest.php
@@ -158,6 +158,7 @@ function testViewsWizardAndListing() {
+    $this->assertRaw(t('The view %view has been saved.', array('%view' => $view4['label'])));

I can see this in tests now, Good work @geertvd, @irfworld and @olli
Patch #16 is ready to commit.
Keeping it RTBC

alexpott’s picture

Title: Add "All Changes Saved" text to views » Add a message when a view saved during wizard creation
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Adding a helpful message to the UI is permitted in the beta evaluation since usability improvements are acceptable. Committed 8f9ece9 and pushed to 8.0.x. Thanks!

  • alexpott committed 8f9ece9 on 8.0.x
    Issue #1949032 by irfworld, geertvd, dawehner: Add a message when a view...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.