CAPTCHA Drupal 8 port

Here is a guide on converting a module.

https://drupal.org/node/1911346

I am working on it at the moment. It would be nice to have a 8.x dev branch to work against.

All changes #4 made.

I have changed the info files on both captcha and image_captcha.

I also separated out the test files and placed them in the lib folder structure as per the guide.

I changed the .inc files and .module files to use t() instead of get_t.

The administration page seems to load but there is a problem with line 194 in captcha.inc.
$language = language(LANGUAGE_TYPE_INTERFACE);

This is in relation to this change: https://drupal.org/node/1450578

I have not made sense of it so far, I think it we have to use a service some how (see https://drupal.org/node/1539454).

Alternatively we could move towards using the controllers, which seems like a more segmented and proper approach.

Made change for this issue.
https://drupal.org/node/1969794

Now examples work.

Patch excluded some unversioned files..fixed.

I talked to some people on IRC and through that I udpated the documentation with regards to https://drupal.org/node/1450578

I have changed the code accordingly.

It is now:
$language = Drupal::languageManager()->getLanguage();

Changing title for better dashboard access.

CAPTCHA 8.x-1.x branch created! ;)

Re uploading the patch from #9 to trigger the testing.

Fixed missing warning image on admin/config/development/performance.

Currently the tests won't run, not sure on the cause. Believe its the branch failing testing.
See: https://qa.drupal.org/pifr/test/552048

Currently getting this error:
Notice: Undefined index: id in theme_fieldset() (line 2870 of core\includes\form.inc).

To recreate:
enable captcha for:
user_login
user_login_block
user_pass
user_register_form

Then view the login page and click between the tabs.

Final change for tonight.

Fixed some stuff to do with CaptchaBaseWebTestCase.

More changes to tests.
646 passes, 114 fails, 104 exceptions, and 151 debug messages

Because of Drupal 8 being HTML 5 I have removed the javascript added from this issue: https://drupal.org/node/881156

I am currently working to find a way to use something similar to the html details element, but constantly open. Currently If I set it to open, it doesn't work. I think it might be a bug in core.

Also firefox does not support html 5 as of yet.

646 passes, 114 fails, 93 exceptions, and 151 debug messages

Getting better! Managed to get the captcha working on the user_login as it was renamed to user_login_form hence the changes to the install.

There is a hack for the details element at the moment, as the #open doesn't work on it. So I added it as an attribute.

This should remove the exceptions. Will do a proper test tomorrow morning.

710 passes, 14 fails, 0 exceptions, and 172 debug messages

Even better, but I am stuck with the testMultipleCaptchaProtectedFormsOnOnePage() test in CaptchaSessionReuseAttachTestCase.php

I believe allowCommentPostingForAnonymousVisitors() fails and causes the issues.

705 passes, 0 fails, 0 exceptions, and 169 debug messages

Done for the core CAPTCHA module!!

Image CAPTCHA does not currently work, but shouldn't be as much of a hassle (famous last words).

The structure of Image CAPTCHA kind of requires us to move to use the new forms system. So this is going to take a while.

Its worth the change though, because it brings all the different pages into form classes.

see: https://drupal.org/node/1800686 for more info on it.

I anticipated this and created an issue before #2024895: Move hook_menu() calls to routing system I will probably keep working here for now. Because CAPTCHA is already working, I will focus on image captcha. After both are working I will move CAPTCHA over to forms.

705 passes, 0 fails, 0 exceptions, and 169 debug messages

Image CAPTCHA is done and moved to routing system for the administration. Both MENU_CALLBACKS will have to be migrated. I think to controllers instead of forms.

CAPTCHA has had the administration moved to routing system, except for the examples. I am unsure how /module/challenge is going to work.

Lots of the logic has been moved out of the admin.inc files.

This should be good to commit to the branch.

A couple quick suggestions (to make D8 and CAPTCHA rock harder!):

1. Could you put a #D8CX note/link on the project page (example: Honeypot), to give people confidence that CAPTCHA will be one of the awesome (and widely-used) modules they can take with them when they upgrade?
2. Could an 8.x dev release be shown on the project page (assuming the module is now at a semi-working state...)? That would help non-devs be able to start testing/using CAPTCHA once D8 betas start rolling out—or even now, as I find the alphas are somewhat usable for testing/kicking the tires.

Many (if not most) of the people using Honeypot also have CAPTCHA installed, and I think it'd be awesome if both modules were ready to go on D8's launch day. It took a really long time for any good (and stable) spam prevention modules to be released for D7. Let's not make that mistake again!

I'm not really the Dev on this. Just some guy doing my thing to help out. I agree with #D8CX, but that is a maintainers pledge. Not really something for us to decide on.

Does the patch work for you? I would love some feedback/patch reviews.

Looks like #23 adds some whitespace issues:

git apply CAPTCHA-Drupal_8_upgrade-12-do-not-test.patch 

CAPTCHA-Drupal_8_upgrade-12-do-not-test.patch:1508: trailing whitespace. 
CAPTCHA-Drupal_8_upgrade-12-do-not-test.patch:1515: trailing whitespace.
CAPTCHA-Drupal_8_upgrade-12-do-not-test.patch:1908: trailing whitespace.
CAPTCHA-Drupal_8_upgrade-12-do-not-test.patch:1931: trailing whitespace.
const CAPTCHA_WRONG_RESPONSE_ERROR_MESSAGE = 
CAPTCHA-Drupal_8_upgrade-12-do-not-test.patch:1939: trailing whitespace.
  
warning: squelched 6 whitespace errors
warning: 11 lines add whitespace errors.

Either way that one was applied to 8.x-1.x :)

The changes from #25 were also committed!

Btw, I've just committed a fix for the whitespaces on 8.x branch, it would be great if you reroll before writing the next patches (or --rebase your repository).

Thanks Wundo!

#25 is the latest. It fixes a few issues.

Sorry about the whitespace!

I will rebase/re-write in the next 24hrs.

Branch passed testing! :)

Next up will be moving more logic out of captcha.admin.inc into either controllers or forms.

Both of the last items from hook menu need to be moved and routes added:

• captcha_point
• examples

Same for image captcha:

• image_captcha_font_preview

Then we can then see about moving the user logic to controllers.

Finally we will move to the configuration system. Which will neaten up the code a bit.

Added 8.x branch releases to the project home page!

@Wundo - Could I please be a maintainer for 8.x branch?

Sure, that would be a honor ;)

Done!

Thanks!! :)

Lets continue maintain 8.x branch :)
Apply new configuration API

Apply Library API according to https://www.drupal.org/node/2169605 and https://www.drupal.org/node/2201089

Implement PSR-4, fix routing and forms api.

test bot

Contains sniffer clean up, test fixes, image_captcha module port and lots of other stuff.

I've rewritten image generation controller using Symfony StreamedResponse class. Now image_captcha works nice and "pretty ready" to be used.

Last fixes and diabling AdminTest because it needs full rewrite.

Reroll

Reverted minor changes in font binaries. Interdiff.txt is the same.

another reroll

Add missing method and other fixes.

Lets move development to GitHub repo to make it easier and more flexible.
https://github.com/M1r1k/captcha

Latest changes are merged in github repo

Linking related issue

EDIT:
Merged into drupal git. This should help fix #2353977: Fatal error on installation.

Is it possible to get a dev release so that we can tag issues? It would make the meta game a little easier. It might also get more people involved.

There is already a dev release ;) 8.x-1.x-dev

Master branch on github has more the less workable version. Be aware of the image_captcha doesn't work with custom fonts (don't know why). You can check it on https://drupal.com/contact.

However I will merge plugin style rewrite soon that will have new image captcha generator lib, plugin system, per form settings and may be even test coverage :)

m1r1k if you're using github please send me a pull request ;)

tks

Sorry Wundo! I posted it on the wrong issue!

The merged fixed an issue, so I just went ahead and did it.

hi, we have replaced old l() and url() functions with new methods. And created tab for image_captcha in module settings.

Thanks for the patch, I'd love to have a small summary from the changes you made... ;)

I'd suggest to close this issue. There's an 8.x-1.x branch, everything that has been worked on has been committed to that a long time ago.

The port is not complete, there are known issues, but we can track that with separate issues.

Thanks Berdir!