Problem/Motivation

Standardize the docblocks for each overrides described in issue #1938680: ViewsStorageController::postSave should be protected comment 5.

Proposed resolution

Update documentation in file core/modules/views/lib/Drupal/views/ViewsStorageController.php and remove Drupal\core

Remaining tasks

Update docblocks for each override ConfigStorageController::xxx().

User interface changes

none

API changes

none

#1938680: ViewsStorageController::postSave should be protected

CommentFileSizeAuthor
#1 ViewsStorageController_docs-1949736-1.patch1.57 KBtoastieAlex

Comments

toastieAlex’s picture

toastieAlex commented
Status: Active » Needs review
StatusFileSize
new ViewsStorageController_docs-1949736-1.patch1.57 KB

Patch for deocblocks.

damiankloip’s picture

damiankloip commented
Status: Needs review » Postponed

We're trying to steer away from issues like this for the time being if possible, as docs can easily wait until code freeze time. IT helps us out as we don't have to keep rolling out bug/refactoring patches for doc changes :)

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Leaving at postponed, but wanted to mention that this is RTBC when we get around to doing it :-)

damiankloip’s picture

damiankloip commented

Ah, splendid :)

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Postponed » Needs work
Issue tags: +Needs reroll

Because we're no longer waiting for code freeze time. Patch no longer applies.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Assigned: toastieAlex » Unassigned

File ViewStorageController.php and the string ConfigStorageController::xxx() no loger exists.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Closed (duplicate)
Issue tags: -Needs reroll

Yes, that class has been removed.