[D7] ProjectUS

hi Nicolas Royo,

sounds like a promising module! but there's some basic errors that need to be addressed.

you're still using the master branch; please remove it.
here's how: http://drupal.org/empty-git-master

there's a substancial amount of errors in PAReview:
http://ventral.org/pareview/httpgitdrupalorgsandboxnicolasroyo1883454git

also, I believe your git clone is malformed:
git clone http://git.drupal.org/sandbox/NicolasRoyo/1883454.git projectus
(it's in the textbox atop of your sandbox page.)

good luck!

cheers,
Luciano

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello Nicolas,

In general:
- Please, follow drupal coding standards http://drupal.org/coding-standards
- Add more comments
- Move css files to subfolder

Manual review:

projectus.info

• You have git meta information about conflict
• package = ProjectUS - should be you project machine name: projectus

projectus.module

• lines: 13, 22, 31, 132, 135, 138: permission machine name 'ProjectUS: access main page ProjectUS' needs to look like 'projectus access main page'
• 76 | Avoid using extra variable, put css string inline in function argument
  

   			$css = "ul.action-links {display:none}";
  			drupal_add_css($css, 'inline'); 

• 101 | if you are including files on all pages, then add them in .info file using sylesheets and scripts arrays
  

   function projectus_init() {
  	drupal_add_css(drupal_get_path('module', 'projectus') .'/projectus.css');
  	module_load_include('inc', 'projectus', 'projectus.functions');
  }

  Additional information you can find on http://drupal.org/node/171205

• 123 | In hook_help, you have very short description: "Project management ProjectUS"
• 196 | Use 't' function for messages. drupal_set_message("'".$node->title."', ".$message." -> ACTIVATED");

projectus.theme.inc

• 21 | Unused variable in foreach $link_id
• 61 | use theme('image') for rendering images.
• 105, 110, 115, 120 | Used $o extra variable just for one output.

.....

There are a lot of submodules and work to do. After you will clean up them - I will get back to review it once more time.

Good luck!

Hi,

I just cloned your project and it looks very promising, but i immediately saw that your indenting is off... check the automated report for hints.

Your also inconsistent with the t() tags .. For example:
'title' => 'Show/Hide tasks',
'description' => 'Show/Hide tasks',
'variables' => array(
'title' => t('Show/Hide tasks')

And '#header' => array('Selected','Task', 'Project', 'Client'),

Another tip may be that the date format can be chosen, instead of using 'Y-m-d'..

Just adding version to title to make this a little easier to find and review.

The project page could be a lot clearer - I have no idea what your module does after reading it :) The text on http://projectus.overtus.com/ run through google translate is much clearer.

Stay away from using hook_init() if you can - this will be executed on every page load. Try to load libraries only where they are needed.

$vacio = TRUE; - sorry we still require english-language variable names.

In projectus_exist_projects_by_client() (and many other functions in projectus.functions.inc) use argument substitution available in db_query() instead of adding arguments directly to the sql query.

I don't believe the sql is vulnerable to injection attacks though, and the rest of the problems are minor.

----
Top Shelf Modules - Enterprise modules from the community for the community.

On your project page did you mean GPLv2? That applies to anything hosted on drupal.org, you don't need to specify that.

You have some security issues listed here: http://ventral.org/pareview/httpgitdrupalorgsandboxnicolasroyo1883454git, please fix those. In projectus.functions.inc, you should switch to using db_query() and variable substitution.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Please set this to "needs review" once the issues on http://pareview.sh/pareview/httpgitdrupalorgsandboxnicolasroyo1883454git are fixed. See also https://drupal.org/node/532400

Fix link git clone.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.