Broken after http://drupalcode.org/project/drupal.git/commitdiff/fc7c38bde839658bd716...

Patch as soon as I get a nid

CommentFileSizeAuthor
#2 1-2-interdiff.txt402 bytesalexpott
#2 admin_menu-register_cache-1950180.2.patch789 bytesalexpott
#1 admin_menu-register_cache-1950180.patch784 bytesyched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new admin_menu-register_cache-1950180.patch784 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new admin_menu-register_cache-1950180.2.patch789 bytes
new 1-2-interdiff.txt402 bytes

Looks good and works when locally tested... small c&p error...

yched’s picture

yched commented

lol @ c/p error - busted !

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed.

Piazza’s picture

Piazza commented
Status: Needs work » Needs review

.

Status: Fixed » Needs work

The last submitted patch, admin_menu-register_cache-1950180.2.patch, failed testing.

yched’s picture

yched commented
Status: Needs review » Fixed

Why reopen a fixed issue?

egger’s picture

egger commented
Status: Fixed » Needs work

It is not fixed, see: http://drupal.org/node/1965552#comment-7319682

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Fixed

Nope it was fixed... and now it needs a new fix and a new issue :)

core has change to use yml for service declarations and for self creating cache bins... I would advise to hold off working on this until... #1167144: Make cache backends responsible for their own storage lands

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.