Closed (fixed)
Project:
FullCalendar
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Mar 2013 at 16:48 UTC
Updated:
23 Dec 2013 at 04:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
patrickd commentedHi!
A simplytest.make-file is only for distributions.
Still - if a module like this one needs an external library it's a best practice to provide a [shortname].make file which automatically downloads the needed dependencies.
So what's needed to make this work on simplytest.me is a fullcalendar.make file.
Your patch does not work because this module requires the js files at
sites/all/libraries/fullcalendar/fullcalendar.min.jsBut when drush unzipps the downloaded file it is in
sites/all/libraries/fullcalendar/fullcalendar-1.6.0/fullcalendar/fullcalendar.min.jscaused by the directory structure in the zip file.
Detailed documentation about drush make files: http://drush.ws/docs/make.txt
So what missing is:
libraries[fullcalendar][download][subtree] = "fullcalendar-1.6.0/fullcalendar"The patch I attached should work this out, thanks for making this work on simplytest.me!
Comment #2
patrickd commentedcorrecting version
Comment #3
patrickd commentedwoops wrong one
Comment #4
patrickd commentedJust tested the patch with simplytest.me itself
Status report page says it works, someone have a second look and rtbc please
Comment #5
bjlewis2 commentedPerfect! Thank you so much!
Comment #6
bjlewis2 commentedAny chance this can get committed soon? I'd like to record a video showing how Simplytest.me can automatically download external libraries using .make files.
Comment #7
hefox commentedWorks for me as well
Comment #8
tim.plunkettSorry for the insane delays.
Committed, thanks!
http://drupalcode.org/project/fullcalendar.git/commit/3290628
Comment #9
bjlewis2 commentedNo problem. I assume you were just dilly dallying with something petty like D8 core. :P