I wandered neck-deep into comment.module today and noticed a couple funny things. One of them is that the equivalent for node_load is _comment_load, even though this is a function likely to be called by other modules. A side-effect of this is any menu items which take a comment argument dynamically need to be:
'admin/foo/bar/%_comment'
...which just looks freaking dumb. :P
This is an API change, so I've put against 7.x.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | comment-comment_load-195072-2.patch | 2.79 KB | coltrane |
| #1 | comment-comment_load-195072-1.patch | 2.79 KB | webchick |
Comments
Comment #1
webchickComment #2
coltranePatch still applied with offset actually! But comment.admin.inc calls _comment_load() so needed to be patched as well.
Comment #3
dries commentedI've committed this patch to CVS HEAD. Thanks webchick and coltrane.
This is an API change and therefore needs to be documented in the 'upgrading modules from D6 to D7' handbook page. Please mark this issue 'fixed' when this change is documented.
Comment #4
webchickWow, thanks!
Docs updated: http://drupal.org/node/224333#comment-load
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.