Menu help text is incorrect (admin/build/menu)

Rowanw - November 25, 2007 - 03:57
Project:Drupal
Version:6.x-dev
Component:menu system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

At admin/build/menu the help text implies that there may be lists of menu items below, however the page does not display any menu items.

Current text

Menus are a collection of links (menu items) used to navigate a website. The list(s) below display the currently available menus along with their menu items. Select an operation from the list to manage each menu or menu item. [more help...]

Suggested

Below is a list of all the menus on your site. [more help...]

Honestly, it doesn't need to say very much.

AttachmentSize
menu_help.patch1.27 KB

#1

catch - November 25, 2007 - 11:26
Status:patch (code needs review)» patch (code needs work)

There doesn't seem to be any need for the url calls (they were there before, but might as well remove them).

Also not really within the scope of this issue but admin/help/menu doesn't mention drag and drop yet.

#2

Rowanw - November 25, 2007 - 12:30
Status:patch (code needs work)» patch (code needs review)

Removed the URLs.

AttachmentSize
menu_help_0.patch1.16 KB

#3

catch - November 25, 2007 - 12:46
Component:language system» menu system
Status:patch (code needs review)» patch (reviewed & tested by the community)

Looks good to me.

#4

Gábor Hojtsy - November 26, 2007 - 08:45
Status:patch (reviewed & tested by the community)» patch (code needs work)

Well, well, this is the primary menu administration page, so it would IMHO be important not to remove Menus are a collection of links (menu items) used to navigate a website.

#5

catch - November 26, 2007 - 09:43

Hmm, well we don't explain what themes are on the theme administration pages, and I'd say menus are far more a generic term than theme (skin etc.), to me it seemed like overkill.

#6

Rowanw - November 26, 2007 - 11:14

I think there's plenty of hints in the individual menu descriptions as well, I don't think there's a need to explain what a menu is on that page, the help text explains that pretty well.

#7

gaele - December 11, 2007 - 15:04
Status:patch (code needs work)» patch (reviewed & tested by the community)

+1 from me too, so I'll try again ;-)

I see another problem: the name "Navigation" is confusing. It suggests that "Primary links" and "Secondary links" are not for navigation. But that's outside the scope.

#8

Gábor Hojtsy - December 12, 2007 - 15:00

Rowanw: You say: I don't think there's a need to explain what a menu is on that page, the help text explains that pretty well. The patch actually removes any description on what a menu is, so how does it explain it pretty well? This seems like a contradiction to me. Although to us, a menu seems like one of the most well known concepts, a newbie can just as well get some help with that short description IMHO, and it does not distract.

#9

catch - December 12, 2007 - 15:06

Gabor, I think Rowanw is referring to: admin/help#menu which has similar text to that being removed by this patch.

#10

Gábor Hojtsy - December 12, 2007 - 15:31

catch: show me people, who read that page :P

#11

catch - December 12, 2007 - 15:46

People who don't know what a menu is??

#12

keith.smith - December 12, 2007 - 19:47
Status:patch (reviewed & tested by the community)» patch (code needs review)

There must be something here I'm not understanding. The original text is misleading in that it refers to things being on the page that aren't, but the new text is a bit terse. Would something like the attached patch clear up the technical inaccuracy of the current text, while leaving the hint about menus?

And, catch and Gabor are both right, in one of the great paradoxes of the computer age.

Nobody reads help text, except when they really, really, need help.

AttachmentSize
menu_help_1.patch1.58 KB

#13

catch - December 12, 2007 - 22:10
Status:patch (code needs review)» patch (reviewed & tested by the community)

Yeah this is good. At the end of the day it doesn't matter if that one explanatory sentence is in if the other one that makes no sense gets fixed :) :)

#14

Rowanw - December 13, 2007 - 05:28

One of my plans for D7 is to improve the visibility of the 'help' links, so they're not in square brackets on the right side of the page. :) But that's another issue.

The latest wording is OK.

#15

Gábor Hojtsy - December 13, 2007 - 10:34
Status:patch (reviewed & tested by the community)» fixed

Great, this one committed, thanks guys.

#16

Anonymous - December 27, 2007 - 10:44
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.