form_set_error doxygen is very poor

looks good. thanks.

We don't use the edit array on form elements since (maybe) 4.7. So the example needs that removed.

Hmmm. I suggested removing the edit array not the whole note about nested arrays. The edit array itself was removed the nested arrays are still handled with this construct as far as it looks from form_get_error(), which I just checked.

This is the text from your patch:

+ *   The name of the form element. If the name of the element is
+ *   'edit[foo][bar]', then you may pass either 'foo' or 'foo][bar' as
+ *   $name. Passing 'foo' will set an error for all its children.

I said we do no use "edit" anymore, so remove "edit":

+ *   The name of the form element. If the name of the element is
+ *   'foo[bar]', then you may pass either 'foo' or 'foo][bar' as
+ *   $name. Passing 'foo' will set an error for all its children.

This is what I said. I did not say anything about whether this is right now or not. I looked into http://api.drupal.org/api/function/form_get_error/6 which says the foo][bar form is supported indeed. Whether passing 'foo' sets an error for all children is a different question. It depends on how form_get_error() is actually used. However, I don't see that this is the case, look into http://api.drupal.org/api/function/_form_set_class/6. It only sets the class or the current element.

So while I pointed out the error with the "edit" element, it did not had any consequences on other parts of the note. Those needed further digging.

Well, if we want to be precise then this is the patch you want. Speaking of children is highly innacurate. Note that this patch can be applied to D5 and D4.7 -- though D4.7 did use $edit but this has nothing to do with form_set_error, actually. We need to work on this error setting thing on D7, these legacy functions are ugly to say the least.

Thanks, committed.