When installing themes in the user's site directory, the full path to the theme is displayed as the description, including the site directory (ie: site/www.mysite.com/themes/mytheme/mystyle). While this is technically correct, it does serve to create a lot of clutter, and exposes the underlying structure of the site more than the site maintainer might feel comfortable.

Attached is a simple patch to strip out the site directory on display.

I admit this patch makes more sense in a mass hosting system like bryght, where the directory structure is irrelevant to the site.. but I just thought I'd roll it and see what you guys think.

CommentFileSizeAuthor
strip-site-dir.patch1.2 KBadrian

Comments

drumm’s picture

Status: Active » Needs work

Why even show the directory?

And this doesn't apply since the forms rewrite.

moshe weitzman’s picture

the site directory is the only useful part of the file path. i'd prefer to keep the path as is, but if we need to cut it down we might as well cut it out.

Jaza’s picture

Version: x.y.z » 6.x-dev

I agree with Moshe. We should either leave the path as it is now, or take it out altogether. Personally, I find it useful, both for helping me find the physical location of my themes, and for helping me distinguish core / multisite / single-site themes. Maybe make the display of this table column a configurable setting, or an access permission?

pasqualle’s picture

Version: 6.x-dev » 7.x-dev
Assigned: vertice@www.drop.org » Unassigned
Priority: Minor » Normal
damien tournoud’s picture

Status: Needs work » Closed (fixed)

This is not the case anymore.

@Pasqualle: please stop bumping crap to 7.x without verifying first that they still apply.