This patch takes the drag and drop functionality from the taxonomy patch (http://drupal.org/node/193333) and re-uses it for forums. The only difference between the two forms is that forums differentiate between terms that are 'containers' and 'forums'. It adds an additional validate function.

CommentFileSizeAuthor
#3 forum_drag_and_drop.patch3.63 KBquicksketch
#2 containers.png6.27 KBcatch
forum_drag_and_drop.patch4.77 KBquicksketch

Comments

catch’s picture

catch
he/him
Primary language English
commented

Quick review. Drag and drop, validation all worked very smoothly. Since the taxonomy patch had some hunk failures, the reset to alphabetical was broken (notices etc.), but I don't think that's the fault of this patch.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work
StatusFileSize
new containers.png6.27 KB

OK as expected with the updated taxonomy drag and drop patch, this works great.

However, forum.module does allow you to put containers within forums - both the help text specifies this, and non drag and drop form allows it. Screenshot attached. Unless I'm missing something the validation is unnecessary here.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new forum_drag_and_drop.patch3.63 KB

Oh... man. I spent a lot of time making it so you could throw validation errors on the taxonomy drag and drop pages. Ah well. It's a good thing to be able to do it anyway even if we don't use it in core, but catch is quite right. Validation is *not* necessary since containers can be inside of forums just fine. Thanks for pointing this out.

Here's a patch that takes out the additional validation and removes the restriction.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Yep, that fixes it. In that case I'm setting this to RTBC but please note it's dependent on the taxonomy patch getting in first.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

$ patch -p0 < forum_drag_and_drop_0.patch
patching file modules/forum/forum.module
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] y
Hunk #1 FAILED at 92.
1 out of 1 hunk FAILED -- saving rejects to file modules/forum/forum.module.rej
patching file modules/forum/forum.admin.inc
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] y
Hunk #1 FAILED at 214.
1 out of 1 hunk FAILED -- saving rejects to file modules/forum/forum.admin.inc.rej

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Closed (duplicate)

Hah, hah. You seem to packaged this already with the taxonomy patch which got committed already.

quicksketch’s picture

quicksketch
he/him
commented

Horribly sorry Gábor! That was an honest mistake. For posterity's sake, #3 above was the same code accidentally rolled into #24 in the taxonomy drag and drop patch.