warning: implode() [function.implode]: Bad arguments. in /home/www/drupal-5.3/sites/all/modules/asin/asin.module on line 206.

CommentFileSizeAuthor
#6 implode-error.patch1.29 KBoadaeh
#3 fix_implode.patch903 bytescurtisc@drupal.org

Comments

robbt’s picture

robbt commented

I noticed that this worked with the Amazon Nodes content type, but it doesn't work for just adding the ASIN field to a content type and typing in the isbn. It will show the image and the price but it doesn't show the author, but displays this error.

jo1ene’s picture

jo1ene commented

I am also having this problem. I didn't when I first installed and started using the module, but I appear to have it now. I will try to track this down.

curtisc@drupal.org’s picture

curtisc@drupal.org commented
StatusFileSize
new fix_implode.patch903 bytes

The problem is because the implode function in theme_asin_field is using the wrong variable. The code right now says the following:

implode(', ', $asin->author)

But that should really be this:

implode(', ', $product->author)

There is no $asin variable in this function and it looks like the latest commit broke this. I've attached a patch to fix it.

Cory Goodwin’s picture

Cory Goodwin commented

This patch work perfectly. Thank you curtisc.

conniec’s picture

conniec commented

Many thanks curtisc! You've made my day!

Connie

oadaeh’s picture

oadaeh commented
Version: 5.x-1.4 » 5.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new implode-error.patch1.29 KB

Actually, there are two places in that line with the wrong variable name. My attached patch handles them both. My patch was created against DRUPAL-5, but applies cleanly to 5.x-1.4.

(I did not change the CSS class name of asin-author, which doesn't appear to be used anywhere, but then, neither is product-author.)

oadaeh’s picture

oadaeh commented
Status: Needs review » Closed (duplicate)

This is a duplicate of http://drupal.org/node/182412.