Hi!

Nice module, I hope this becomes part of core one day. I've implemented it on my site and it works as advertised, although, I'm only using the delay. I made two small changes, one is a bug and one is a new feature:

1. Notify on/off var was named wrong.

see this:

// Should the user be advised about the remaining login attempts?
-   $notice_user = variable_get('login_security_notice_available_attempts', LOGIN_SECURITY_NOTICE_AVAILABLE_ATTEMPTS);
+
+   $notice_user = variable_get('login_security_notice_attempts_available', LOGIN_SECURITY_NOTICE_ATTEMPTS_AVAILABLE);

2. In our case, we didn't want to increase the delay with each attempt, so I made that a separate option.

Thanks! jacob

P.S. Partially funded by CivicActions and Amnesty International

Comments

ilo’s picture

Assigned: Unassigned » ilo
Status: Needs review » Reviewed & tested by the community

Thanks for the patch!!! I didn't realize that bug (because of the variables already populated with the development I guess). The other option (I've included) should no need that checkbox.. I mean, if you set delay to 0 then the delay is not considered at all. In any case I'll leave the checkbox in the code for other people with doubts about that option.

Again, thanks for your help!!
(changes will be included in the new release.)
(New release will be stable release.)

ilo’s picture

Status: Reviewed & tested by the community » Fixed

Commited and released as stable. Thank you very much!

ilo’s picture

Status: Fixed » Closed (fixed)

Finished