Closed (fixed)
Project:
Login Security
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
26 Nov 2007 at 05:28 UTC
Updated:
15 Jan 2008 at 21:54 UTC
Hi!
Nice module, I hope this becomes part of core one day. I've implemented it on my site and it works as advertised, although, I'm only using the delay. I made two small changes, one is a bug and one is a new feature:
1. Notify on/off var was named wrong.
see this:
// Should the user be advised about the remaining login attempts?
- $notice_user = variable_get('login_security_notice_available_attempts', LOGIN_SECURITY_NOTICE_AVAILABLE_ATTEMPTS);
+
+ $notice_user = variable_get('login_security_notice_attempts_available', LOGIN_SECURITY_NOTICE_ATTEMPTS_AVAILABLE);
2. In our case, we didn't want to increase the delay with each attempt, so I made that a separate option.
Thanks! jacob
P.S. Partially funded by CivicActions and Amnesty International
| Comment | File | Size | Author |
|---|---|---|---|
| option_for_delay_and_variable_name_fix.patch.txt | 2.81 KB | JacobSingh |
Comments
Comment #1
ilo commentedThanks for the patch!!! I didn't realize that bug (because of the variables already populated with the development I guess). The other option (I've included) should no need that checkbox.. I mean, if you set delay to 0 then the delay is not considered at all. In any case I'll leave the checkbox in the code for other people with doubts about that option.
Again, thanks for your help!!
(changes will be included in the new release.)
(New release will be stable release.)
Comment #2
ilo commentedCommited and released as stable. Thank you very much!
Comment #3
ilo commentedFinished