Forums vocabulary title not localizable

Here is a patch.

Where exactly is this title displayed? As far as I can tell, the vocabulary is only saved once, so changing the localization won't affect the title if you've already caused _forum_get_vid() to be invoked one way or the other...

Steven, this title is surely displayed if you use some multifaceted navigation tool (eg. taxonomy navigation modules).

Those were really two points, I guess it wasn't clear.

My point is that this patch does not appear to solve the problem if you already have an untranslated forums title in the database. Changing the localization at that point will not affect it, as the variable "forum_nav_vocabulary" will be set.

I just realized, this patch will fail with multi-language sites. Only one localization will be stored in the database, and keep being used regardless of user choice.

This really needs a different fix for this and the earlier reason.

Steven, vocabulary names are single language all across Drupal. It should not mean that Drupal should enforce an English name on the forums vocab, should it? The idea is to populate the title field with the site default locale on forum setup time.

-1: We should never ever t() any user submitted content. i18n will fix this for you, because it allows translation of taxonomies.

Ber, we are not applying t() to user submitted content!

I'm still in Ber's camp. This whole patch relies on a bunch of odd conditions:
a) Locale.module must be enabled.
b) An appropriate translation must be installed.
c) The admin has never visited the forums admin screen before.

If and only if all of these are satisfied, the Forums vocabulary name will be translated, but only once, into the language of that the admin is using. For all intents and purposes, this string can be considered untranslatable.

Not going to fix this using the locale system.