Hi,

It would be nice to allow block management to people that cannot manage site configuration (like content editors).

CommentFileSizeAuthor
#6 blocker-1953594-6-permissions.patch2.67 KBKroKroDile
#5 blocker-1953594-5-permissions.patch2.74 KBKroKroDile
#1 blocker-1953594-1-permissions.patch2.87 KBsimon georges

Comments

simon georges’s picture

simon georges commented
Status: Active » Needs review
StatusFileSize
new blocker-1953594-1-permissions.patch2.87 KB

Patch provided.

This patch is part of the #1day1patch initiative.

randallknutson’s picture

randallknutson commented

For the blocker_ui permissions I'm good with this approach but I'm thinking we could either tie the permissions into node edit permissions or mirror those. The idea is that an end user with permission to edit a node should have the ability to change the blocks on that page as well but not other nodes.

simon georges’s picture

simon georges commented

Either tying them to the node or adding them (something like (user_access("edit not") && user_access("manage blocks")) is totally fine by me, as long as it's possible to give access to content editors that shouldn't alter the site configuration.

randallknutson’s picture

randallknutson commented
Status: Needs review » Needs work

Updated in ed6cf64

I tied it to the node permissions for now. I'm open to making this more extensive and customizable but this is better than the high level admin that was there.

I'll leave this open to discuss even better options moving forward.

KroKroDile’s picture

KroKroDile commented
StatusFileSize
new blocker-1953594-5-permissions.patch2.74 KB

Hi,

Here a patch updated (the code has changed).

KroKroDile

KroKroDile’s picture

KroKroDile commented
StatusFileSize
new blocker-1953594-6-permissions.patch2.67 KB

Better with clean code

simon georges’s picture

simon georges commented
Status: Needs work » Needs review

Changing status back to "Needs review", to have maintainer feedback.

simon georges’s picture

simon georges commented
Issue summary: View changes

Fix grammar.

kyletaylored’s picture

kyletaylored commented
Issue summary: View changes

This worked for me. +1

kyletaylored’s picture

kyletaylored commented
Status: Needs review » Reviewed & tested by the community

Tested and works well.

kyletaylored’s picture

kyletaylored commented
Status: Reviewed & tested by the community » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.