Comments

justinchev’s picture

Assigned: Unassigned » justinchev
justinchev’s picture

StatusFileSize
new582 bytes

I've changed the name to include capitalization. I've also updated the ctools.info file to match the new D8 format which included renaming it to ctools.info.yml.

justinchev’s picture

Status: Active » Needs review

Sorry forgot to change to 'needs review'. See above patch.

Status: Needs review » Needs work
Issue tags: -capitalization

The last submitted patch, capitalisation-project-name-1954040-2.patch, failed testing.

justinchev’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, capitalisation-project-name-1954040-2.patch, failed testing.

justinchev’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +capitalization

The last submitted patch, capitalisation-project-name-1954040-2.patch, failed testing.

justinchev’s picture

Is this failing because Ctools can't currently be enabled on D8? The patch above only changes the Ctools.info file to the new format (.info.yml) so that it at least appears under the modules list.

klonos’s picture

That should be it I guess. Anyways, we need to fix this for 7.x/6.x too and also change the project name in d.o too.

PS: related (not to the issue itself, but rather the task of fixing it against multiple branches): #1171958: Allow files to be assigned to branch(es)/version(s) and thus tested against it

justinchev’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new4.69 KB

Attached patch is for D7 version of CTools. I changed the capitalization of the project name, but also changed other capitalization issues in the .info descriptions.

justinchev’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev

Woops I guess that I shouldn't have changed the issue to 7.x-1.x-dev? Changing it back to D8. Thought I might need to in order to associate the patch with D7.

Klonos re. #10 - I looked at that link but it doesn't actually say what you should do to assign your patch to a version? Found a bit more info here https://drupal.org/node/332678 - looks like me adding the 'd7' in the patch name has caused it to be skipped anyway. Do you need to submit all the patches together in one comment, or is it ok to submit them split up?

justinchev’s picture

OK here are the D6, D7 & D8 patches.

For D8 I've renamed all the '.info' files to '.info.yml' and also updated all of their formats so that they are compatible with D8 and show up in the modules list.

Status: Needs review » Needs work
justinchev’s picture

OK so D8 patch failed again possibly because the CTools module can't be enabled. The changes I've made check out on my local environment, and the CTools modules show up under the module area, along with their descriptions, dependencies, version info etc.

So what happens now? This patch is something that should probably be committed, but won't be able to pass the testing.

justinchev’s picture

Status: Needs work » Needs review
StatusFileSize
new9.24 KB

Someone pointed out that you shouldn't include the 'version: VERSION' bit in the .info.yml files as it's added by the packaging script on drupal.org. I've removed those.

D7 & D6 patches in #13 still relevant.

Status: Needs review » Needs work
klonos’s picture

@justinchev: Nope, there currently is absolutely no way to assign patches to be tested against a specific version of core (for example issues like this one here where we have multiple patches for various versions of core.). That's why I filed #1171958: Allow files to be assigned to branch(es)/version(s) and thus tested against it

damienmckenna’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes

The 8.x-1.x branch has been abandoned, 8.x-2.x is being rewritten from scratch, so this is no longer relevant to D8. I'm moving it back to the 7.x-1.x branch.

justinchev’s picture

Status: Needs review » Needs work
damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new10.67 KB

@justinchef: A good portion of your patch is lines removed from the info files because you created it against a dev checkout, e.g. the "Information added by Drupal.org packaging script" sections. This patch was rerolled off a git checkout so it doesn't have those lines. I also standardized on "Chaos Tools Suite" because grammatically speaking it's a suite of tools, not a suite of tool. I also added "(CTools)" to the primary module's name so that when you're on the module page you can search for "ctools" and will be able to find it.

damienmckenna’s picture

Assigned: justinchev » Unassigned
chris matthews’s picture

Status: Needs review » Needs work
Issue tags: -capitalization +Needs reroll

The patch in #22 does not apply to the latest ctools 7.x-1.x-dev and if still applicable needs a re-roll.

daiwik.addweb’s picture

Status: Needs work » Needs review
StatusFileSize
new7.23 KB

@Chris Matthews, Here's the patch, on behalf of your mentioned comment in #24.

kindly review it and let me know your views on the same.

Thanks!.