this happens because the code thinks the "Add New Node" button is a single textfield.

editable fields hides the save button for those...

here is a patch that fixes it.

CommentFileSizeAuthor
#7 1954456-7-table-drag-excluded.patch1.09 KBjoelpittet
#6 inline-entity-form-s-save-button-1954456-6.patch606 bytesdenes.szabo
#2 patch-editablefields.fix-inline-entity-form.patch606 bytesrsvelko
#1 editablefields.fix-inline-entity-form.patch540 bytesrsvelko
editablefields.fix-inline-entity-form.patch678 bytesrsvelko

Comments

rsvelko’s picture

rsvelko commented
StatusFileSize
new editablefields.fix-inline-entity-form.patch540 bytes

remove 1 emlty line from patch - to minimize changes

rsvelko’s picture

rsvelko commented
StatusFileSize
new patch-editablefields.fix-inline-entity-form.patch606 bytes

okay - this one is tested and works - added the jquery .parent() several times to make it work...

nicolas bouteille’s picture

nicolas bouteille commented
Issue summary: View changes

same problem with Paragraphs module
Actually Editablefields and Paragraphs play very well together (better than Inline Entity Form in my experience), but the "Add new paragraphs item" button is missing when no paragraph item has been added yet. My workaround until then was to programmatically create a useless first item at content creation... but now I can find a better solution

nicolas bouteille’s picture

nicolas bouteille commented

here is the hack updated for paragraphs as well

<?php
$('.editablefield-item').find('[class*="field-widget-"]:not(.field-widget-inline-entity-form, .field-widget-paragraphs-embed)').parent().parent().parent('.editablefield-item').once('editablefield', function() {
?>
rooby’s picture

rooby commented
Status: Needs review » Needs work

This needs a reroll for the latest version

denes.szabo’s picture

denes.szabo commented
Status: Needs work » Needs review
StatusFileSize
new inline-entity-form-s-save-button-1954456-6.patch606 bytes

I re-rolled the patch against the latest dev. This patch solved my no upload, no save button problems! THX!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 1954456-7-table-drag-excluded.patch1.09 KB

There's a false positive with tabledrag, this patch excludes it from being considered the single field

  • joelpittet committed fe078ff on 7.x-1.x 
    Issue #1954456 by rsvelko, joelpittet, Denes.Szabo: inline entity form '...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

I've pushed this fix to the dev branch, please let me know if there are any side-effects

  • joelpittet committed 49ad6ce on 7.x-1.x 
    Issue #1954456 by rsvelko, joelpittet, Denes.Szabo: Ensure no more false...
rsvelko’s picture

rsvelko commented

From the issue's OP: Thanks a ton for fixing this!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Sorry for the super delay. I hadn't comaintained this for long and didn't run into this issue for myself until the other day.

rsvelko’s picture

rsvelko commented

Seems like the community didn't run into this bug much either.
If it were more important people would comment more, me included.
So yeah, thanks again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.