Closed (outdated)
Project:
Privatemsg
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Mar 2013 at 16:19 UTC
Updated:
24 Apr 2025 at 04:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
duaelfrThis patch is part of the #1day1patch initiative.
Comment #2
duaelfrThe previous patch had a few bugs :
- the message was not showing when there was no result for the first autocompleted name
- the message was not showing when two consecutive matches returned no results
- selecting the message when no results found were removing the searched string instead of letting the user correct it
Comment #4
duaelfrThe same with test included (and a test only patch for TDD)
Comment #6
duaelfrAnd again, without a stupid copy/paste mistake...
Comment #7
duaelfr...
Comment #8
berdirHm. Not sure, this seems to be the standard behavior for autocomplete in core? Also, the way this is implement makes it a selectable option, which is a bit weird?
I would create separate assertions for this. This looks a) ugly and is unnecessary hard to debug when one of those assertions is no longer true.
No need for "Sorry".
Comment #9
duaelfrFirst, it is true that the autocomplete fields in core do not provide any message when the result is empty but it is not a good reason to do the same. Most users do not pay attention to the loading icon, so they do not understand how the field is working. Adding a message when their search does not return any result is an improvement for them.
Second, I did not find a way to return a non-clickable message so I used the already inputted content to make no difference if the user clicks the message.
There are the new patches following your advices.
Comment #10
ptmkenny commented#9: privatemsg-add_string_on_empty_autocomplete-1954496-9-test-only.patch queued for re-testing.
Comment #11
ivnishComment #12
andypostD7 is not yet outdated
Comment #13
ivnishAutomatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.