Created sandbox module for adding icons

Wow... we have the same exact use case! Here is a patch with some icons for Workbench and Commerce UI.

Unsure if this is the best way to do this - perhaps navbar could allow for some type of hook that lets contribs supply their own icons?

Screenshot of #1

Hmm yes a more basic cart icon would probably be better. Feel free to provide additional patches anyone who wants to better these icons.

@pjcdawkins - here is an alternate patch that does what you mentioned: I put the css for contrib icons in their own file and updated the 'store' icon for commerce to use a new "cart" that is more consistent with the other navbar icons. Even though I like the Commerce logo, I am not sure if we can even use it since its probably copyrighted and you are right- it doesn't register in grayscale. These icons can be used as they were drawn by me (using Gimp!).

Also attached is a new screenshot and a ZIP of the Gimp files I created for help with future contributions to this solution.

Would love to see an icon in there for the Apps module too.

Added an apps icon.

something up with that last patch. wont apply with drush make.

3rd try, this time using --binary switch to git diff

bumping this. yes, thats right.

I like this additions, but I think this should be added to the modules and integrated from there. So every module can add it's own icons.

Do we have a code example for how modules would define their own icon? I'd be happy to break the patch up if we can get some guidance here.

I've added a blurb about icons to the project description and the documentation page.

If you just need to add CSS or JS, you can implement hook_navbar and just return an #attached key with the necessary assets like this:

function workbench_navbar() {
  $items['workbench'] = array(
    '#attached' => array(
      'css' => array(drupal_get_path('module', 'workbench') . '/workbench.navbar.icons.css'),
    ),
  );

  return $items;
}

I would rather we kept JS, CSS and icons with their respective modules. You'll have more control of the assets in the long run this way.

We pull the SVG icons from this library: https://github.com/ry5n/libricons

Also note that we're leading with SVGs and falling back to PNG like this:

.navbar-bar .navbar-icon-home:before {
  background-image: url("../icons/bebebe/house.svg");
}
.no-svg .navbar-bar .navbar-icon-home:before {
  background-image: url("../icons/bebebe/house.png");
}
.navbar-bar .navbar-icon-home:active:before,
.navbar-bar .navbar-icon-home.active:before {
  background-image: url("../icons/ffffff/house.svg");
}
.no-svg .navbar-bar .navbar-icon-home:active:before,
.no-svg .navbar-bar .navbar-icon-home.active:before {
  background-image: url("../icons/ffffff/house.png");
}
.navbar-bar .navbar-icon-menu:before {
  background-image: url("../icons/bebebe/hamburger.svg");
}
.no-svg .navbar-bar .navbar-icon-menu:before {
  background-image: url("../icons/bebebe/hamburger.png");
}

This fix has been in place for two weeks. I'm going to assume that it is working. If you find that the fix does not resolve the issue, please reopen this issue or create a new one.

Here is a quick patch for the latest navbar as of this posting. The next step is to break these out into individual patches for the contrib modules. Note: I am using a svg from wikimedia commons as it is free to reuse (http://commons.wikimedia.org/wiki/File:Shopping_cart_font_awesome.svg)

@brantwynn Can you please clarify where you made the individual patches for the contrib?

Re #24 - I haven't gotten around to making those yet, but here is your model: #2217419: No Icon for second level nav bar

+1, and thanks for the work so far.

I have created a sandbox module that loads the icons and css for the Workbench and Store icons used in this issue thread. I thought this might be a good place to easily implement these icons, without needing to add them in the main Navbar module, at least as an interim solution. I welcome input and if there are other icons you want to add, please let me know on the issue queue for the module.

Thanks,

Okay. Honestly you should have probably created a new thread and referenced this one but whatever... kind of a zombie issue at this point.