Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.
core/modules/editor/js/editor.js: line 72, col 17, Expected '===' and instead saw '=='.

CommentFileSizeAuthor
#1 1955288-core-js-jshint-editor-1.patch688 byteslilster66

Comments

lilster66’s picture

lilster66 commented
Assigned: Unassigned » lilster66
Status: Active » Needs review
StatusFileSize
new 1955288-core-js-jshint-editor-1.patch688 bytes

Hi,

I've added a patch for this. I got the following errors:

Line 72: if (trigger == 'serialize') {

Expected '===' and instead saw '=='.

Line 109: })(jQuery, Drupal);

'jQuery' is not defined.

Line 109: })(jQuery, Drupal);

'Drupal' is not defined.

I don't think the jQuery and Drupal lines are an issue.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

They're not indeed, check the config file in the issue linked in OP. There are a bunch of globals defined.

Tested & works well, thanks :)

lilster66’s picture

lilster66 commented

Cheers :-)

I'm at a starting to contribute to Drupal event, http://www.meetup.com/a-bit-of-everything-drupal/. Thought I'd start with something straight forward :-P

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed fd6594b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.