Add support to create custom blocks [#1955904]

Comment	File	Size	Author
#7	profiler-blocks-1955904-07.patch	3.68 KB	jhedstrom
#5	add_block_support-1955904-5.patch	2.72 KB	jyee
#1	add_block_support-1955904.patch	2.33 KB	jyee

Comment #1

jyee commented 29 March 2013 at 00:33

Status	File	Size
new	add_block_support-1955904.patch	2.33 KB

First attempt to provide the functionality is attached.

Log in or register to post comments

Comment #2

jyee commented 29 March 2013 at 16:17

Status:

Active

» Needs review

oops. forgot to set status to needs review.

Log in or register to post comments

Comment #3

mariacha1 commented 5 April 2013 at 01:07

Status:

Needs review

» Needs work

It's a good start, but for blocks, since there isn't any built-in validation like there is with node_save(), a wrongly-entered value will fail the install with an ungraceful pdo error. Here's one of the ways I got it to die:

; a wrong type block
blocks[third][body] = Here's the body
blocks[third][info] = New info
blocks[third][format] = full_html
blocks[third][theme] = junk_theme
blocks[third][status] = test
blocks[third][weight] = test
blocks[third][region] = 5
blocks[third][custom] = 15
blocks[third][visibility] = -4
blocks[third][pages] = junk'page
blocks[third][title] = Here's a junk string
blocks[third][cache] = -1

Second, there's an easily-fixable bug. There should be a default value in the 'format' field. So this code:
'format' => $block['format'],
should be:
'format' => isset($block['format'])? $block['format'] : 'full_html',

Finally, the "info" field in the blocks_custom table must be unique. Is there a way to check for that before trying to save the block?

I can attempt to fix these things later...

Log in or register to post comments

Comment #4

jyee commented 8 April 2013 at 22:42

Thanks, I can take a look into error checking, but theoretically, content is being created by a developer, so i'm not sure how far down the rabbit hole we should go on that.

I'll update it to set the default format to plain_text, as that exists in both minimal and typical install profiles (full_html only exists in typical) and should be a safer default.

As for the unique info field, we can check for that, by storing previous block info and validating against it. I did something similar in the nested menu node creation, but I'm concerned that continued use of that process could start consuming much more memory and become a problem.

Log in or register to post comments

Comment #5

jyee commented 12 April 2013 at 00:39

Status:

Needs work

» Needs review

Status	File	Size
new	add_block_support-1955904-5.patch	2.72 KB

Updated patch to use plain_text when a format isn't declared. I've also added a check for the unique info field.

There's a change to execute the block insert within the foreach loop. While executing once at the end is technically more efficient, it creates a problem where a single record failure could fail the entire set of blocks.