Closed (outdated)
Project:
Views Infinite Scroll
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Mar 2013 at 17:19 UTC
Updated:
27 Mar 2020 at 20:12 UTC
Jump to comment: Most recent
Comments
Comment #1
cwithout commentedOne issue with this patch is that Views Infinite Scroll doesn't depend on the Libraries module. The plugin can be installed in this module's js directory. Maybe you could change your patch to install the that location like the Drush command does.
Comment #2
Ciraxis commentedYes but i don't know if we can realise that without libraries. But i thaught the common way to add third party javascript is with the libraries api?
Comment #3
cwithout commentedYes, the preferred way to add 3rd party libraries is to use the Libraries API. But as far as I know, it's not yet a strict requirement. A module can choose to allow libraries to be installed in its own directory -- as this module does.
There's nothing wrong with making the Libraries API required. But to do so, you'll also have to include in your patch changes that remove the ability to add the library to the module's js directory, update the Drush integration, and handle informing users who have already installed the js library in the
~/views_infinite_scroll/jsdirectory of the change when they update. You can't just change the .info file to require the Libraries API module without those other changes.Seeing as those make it larger change than the scope of your issue, you might be better off having your patch install to the js directory as like the Drush integration does -- or opening a separate ticket that deals with requiring the Library API, then coming back to this one once that one's closed.
According to the docs (http://drush.ws/help/5#make), you can use the following to install to the module's js directory.
Comment #4
honza pobořil commented