Title area handler sets the title even when it should not (results in "Welcome to Drupal" never going away)

Tagging :)

The handler_type is only for area plugins, so cleaning this up a bit.

I've tested the patch and reviewed the changes and this fixes my problem. So this is RTBC.

However in testing the patch has raised some concerns about the ui... see #1957214: Title setting in views UI does not indicate when the title might be overridden

:)

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/area/Title.phpundefined
@@ -50,12 +50,14 @@ public function buildOptionsForm(&$form, &$form_state) {
+    if (!empty($this->options['title']) && ($this->areaType != 'empty' || empty($results))) {

Is there a different issue here? As the title handler is only available for empty areas, so they shouldn't be even used unless the view is actually empty.

Like this, just an idea. As template_preprocess_views_view will check the view is empty before calling render() on the empty area handlers.

Sorry for doing this on RTBC :)

I can't tell if this is RTBC or not?

@dawehner, I was only thinking of not calling preRender for empty area if the result is empty. Not to do with the setting, and the title handler is only available for empty areas currently?

Yep, that sounds good. The tests look good to me.

Interdiff just shows the change I made to Title.php.

#13: 1956912-13.patch queued for re-testing.

@damiankloip marked #1961184: "Welcome to Drupal" title (frontpage view "no results" behavior) persists even when there are results as a duplicate. I spent 30 minutes trying to find the bug report that I was sure must exist for this before I filed it, so please let's put more information in the issue summaries. See that issue for an example of a good start to a summary, or review http://drupal.org/node/1155816. I searched for "no results" and "global title override" and "Welcome to Drupal" and many many combinations of these keywords, and never found this issue.

For maintainers: One result of this bug is that the "Welcome to Drupal" site title persists even after content is added to the site.

Every single site builder will run into this bug, so this is major.

:)

This will need a re-roll because human_name no longer exists.

W00t!

Committed and pushed to 8.x. Thanks!