Closed (fixed)
Project:
Yandex.Metrics
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Mar 2013 at 21:48 UTC
Updated:
30 Apr 2013 at 07:29 UTC
Jump to comment: Most recent file
Comments
Comment #1
Konstantin Komelin commentedtagged
Comment #2
kalabroHourly traffic chart. Used mainly for testing grids and may be useless for our users :)
Comment #3
Konstantin Komelin commentedFantastic! Great job!
I some cases it can be useful for users.
Some ideas how to improve it:
1)
Let's replace this
+ return t('There is no information about page views and visitors for the selected date range.');with this
+ return t('There is no information about hourly traffic for the selected date range.');2)
It would be reasonable to have capital letter in every word of report title, e.g. 'Hourly Traffic' because all other reports are following this way. But we can negotiate this point. I don't mind to change all titles to normal case.
Wdyt?
3)
What do you think if we shift a bit blue bars to the right if they are alone (without red ones)? You can test it on our d7.komelin.com counter id.
But not critical, we can do it after release or leave it as is.
Comment #4
Konstantin Komelin commented4) You set $width = 750; . But what if user has sidebars enabled and his theme has only 960 width?
I understand that this chart should be wide but can we someway make it fluid of reduce the width?
Comment #5
kalabro1) Sure.
2) Let it be capitalized.
3) Unfortunately I don't know how to center specific bars.
4) Yes, It's easy to narrow it down with
'#bar_size' => array('#size' => 4, '#spacing' => 3)param.Which width is prefered? I use Seven theme so I like 750px :)
I really want to use more soft colors.
Comment #6
Konstantin Komelin commentedUse any colors for this chart which you like!
3) Please don't care about that.
4) I'd prefer 500px as other chart have but it can make сhart unreadable.
So I have another suggestion. What if we apply one of the Responsive Design principle 'fluid media', in other words add some CSS rule for images to yandex_metrics_reports.css:
Images will scale automatically.
Comment #7
kalabroWhat do you think about 500px width chart?
--
Comment #8
Konstantin Komelin commentedLooks good. Keep it up!
Comment #9
kalabroCommited after some fixes:
http://drupalcode.org/project/yandex_metrics.git/commit/7f34548e388e0906...
Added css for fluid images:
http://drupalcode.org/project/yandex_metrics.git/commit/f47ecf6d63fa82f8...
Comment #10
kalabroReopen it for one more chart.
Comment #11
Konstantin Komelin commentedDecided not to add new charts for 7.x-2.0-alpha. Maybe later in separate issue.
Comment #12
kalabroAdded new report "Demography of Visits".
Commit: http://drupalcode.org/project/yandex_metrics.git/commit/ca9af711e3a9235b...
Comment #14
kalabroOops, I didn't want to test patch from #2.
#12 needs review.
Comment #15
Konstantin Komelin commentedThis issue is in past.
I've created separate issue #1983080: Demography of Visits chart.
Please use it instead this issue. Thanks.