Add more charts for 7.x-2.0 release.

Comments

Konstantin Komelin’s picture

tagged

kalabro’s picture

Status: Active » Needs review
StatusFileSize
new4.1 KB
new32.13 KB

Hourly traffic chart. Used mainly for testing grids and may be useless for our users :)

2013-04-22_02-41-36.png

Konstantin Komelin’s picture

Status: Needs review » Needs work

Fantastic! Great job!
I some cases it can be useful for users.

Some ideas how to improve it:
1)
Let's replace this
+ return t('There is no information about page views and visitors for the selected date range.');
with this
+ return t('There is no information about hourly traffic for the selected date range.');
2)
It would be reasonable to have capital letter in every word of report title, e.g. 'Hourly Traffic' because all other reports are following this way. But we can negotiate this point. I don't mind to change all titles to normal case.
Wdyt?
3)
What do you think if we shift a bit blue bars to the right if they are alone (without red ones)? You can test it on our d7.komelin.com counter id.
But not critical, we can do it after release or leave it as is.

Konstantin Komelin’s picture

4) You set $width = 750; . But what if user has sidebars enabled and his theme has only 960 width?
I understand that this chart should be wide but can we someway make it fluid of reduce the width?

kalabro’s picture

1) Sure.
2) Let it be capitalized.
3) Unfortunately I don't know how to center specific bars.
4) Yes, It's easy to narrow it down with '#bar_size' => array('#size' => 4, '#spacing' => 3) param.
Which width is prefered? I use Seven theme so I like 750px :)

I really want to use more soft colors.

Konstantin Komelin’s picture

Use any colors for this chart which you like!

3) Please don't care about that.
4) I'd prefer 500px as other chart have but it can make сhart unreadable.
So I have another suggestion. What if we apply one of the Responsive Design principle 'fluid media', in other words add some CSS rule for images to yandex_metrics_reports.css:

.yandex_metrics_reports-report img {
  max-width:100%;
}

Images will scale automatically.

kalabro’s picture

StatusFileSize
new16.35 KB
new17.12 KB

What do you think about 500px width chart?

chart.png
--
chart (1).png

Konstantin Komelin’s picture

Looks good. Keep it up!

kalabro’s picture

kalabro’s picture

Status: Fixed » Active

Reopen it for one more chart.

Konstantin Komelin’s picture

Status: Active » Closed (fixed)

Decided not to add new charts for 7.x-2.0-alpha. Maybe later in separate issue.

kalabro’s picture

Status: Closed (fixed) » Needs review
StatusFileSize
new30.28 KB
new11.24 KB

Added new report "Demography of Visits".
Commit: http://drupalcode.org/project/yandex_metrics.git/commit/ca9af711e3a9235b...

chart_gender1.png

chart_gender2.png

Status: Needs review » Needs work

The last submitted patch, 1957550-hourly_traffic-2.patch, failed testing.

kalabro’s picture

Status: Needs work » Needs review

Oops, I didn't want to test patch from #2.
#12 needs review.

Konstantin Komelin’s picture

Status: Needs review » Closed (fixed)

This issue is in past.

I've created separate issue #1983080: Demography of Visits chart.
Please use it instead this issue. Thanks.