I suppose this should be three patches, but this is all so foolishly premature to be patching this at all when so much of core isn't ported to Twig yet. In any case, wanted to see if I could get Zurb running in D8 using Twig and so far it sort of works, but to get it to do so, I needed to

- convert the .info to a .info.yml file
- get rid of the 'classes not found' error in node.html.twig (should be attributes.class).
- I also brought over the documentation comments from the Twig version of Stark except where I knew it to be wrong (e.g. incorrectly says that 'title' holds the node title, when in fact it is 'label' and 'title' is null; the actual Stark code uses node.title).

CommentFileSizeAuthor
zurb_foundation_yaml_plus_classes_fix.patch10.97 KBergophobe

Comments

chrisjlee’s picture

chrisjlee commented

Awesome thanks! I'll review this patch shortly this weekend.

ergophobe’s picture

ergophobe commented

I just started playing with this because it's the only contrib theme that I found that's far enough along to test.

Just curious where you're focused at the moment - is it worth it to file issues and patches on this branch, or is it better to wait until core is further along?

kevinquillen’s picture

kevinquillen commented

Thanks - will test today.

As far as Twig goes, yeah - I will need help spotting things like that.

kevinquillen’s picture

kevinquillen commented
Assigned: ergophobe » kevinquillen
kevinquillen’s picture

kevinquillen commented

The latest snapshot of Drupal 8 won't install on my machine. I'll attempt this again tomorrow.

kevinquillen’s picture

kevinquillen commented

Related: http://groups.drupal.org/node/292068

ergophobe’s picture

ergophobe commented

Also relevant is pixelmord's Twig sandbox
http://drupal.org/sandbox/pixelmord/1750250

updated 5 days ago
http://drupal.org/project/user/499438

kevinquillen’s picture

kevinquillen commented

I am going to try the latest D8 snapshot today to see if I can install it. The previous version I had did not have Twig/yaml examples or support (seemingly?) for contrib themes.

micheas’s picture

micheas commented

@kevin you need the twig fork of drupal 8 to use twig.

After all the templates have been converted there will be one large merge commit.

http://drupal.org/sandbox/pixelmord/1750250 is the link to get started.

kevinquillen’s picture

kevinquillen commented

What the f... okay. Did not know that. Trying now.

kevinquillen’s picture

kevinquillen commented

Now I am totally lost.

The theme neither works as it were or with this patch applied. When I apply the patch, the theme doesn't appear at all. Without it, it says it is not compatible with Drupal 8. I can't make heads or tails of pixelmords sandbox at all.

I followed the instructions and it isn't working. On top of that, there is a note in the documentation on that sandbox that says:

All Twig work in now being done in the Drupal core issue queue.

ergophobe’s picture

ergophobe commented

pixelmord's sandbox is only Twig for the Stark theme (nothing ported to core templates last I looked.

And in any case, it is neither here nor there for the patch I propose, which is just to get Zurb up and running minimally some people can test and hack... of course if you can't get D8 running with the latest source, then I guess getting Zurb running is rather beside the point.

Sorry - but personally I'm under some tight deadlines for the next few weeks, so I can't be of much assistance.

kevinquillen’s picture

kevinquillen commented

Gotcha. I am going back to D8 snapshot to try.

chrisjlee’s picture

chrisjlee commented

It's ok. I've been doing twig conversions for the past month or so with the twig team.

Kevin, if you're willing you can assign this task to me.

kevinquillen’s picture

kevinquillen commented

If the D8 snapshot is up to date, then I should be fine. The only issue was the snapshot I received in #5 didn't install (fatal error on install screen).

chrisjlee’s picture

chrisjlee commented
Status: Needs review » Fixed

Sorry it took so long. I just went ahead and committed it: http://drupalcode.org/project/zurb-foundation.git/commit/48eff5b

@ergophobe: thanks for the patch. Had to reroll some things.

ergophobe’s picture

ergophobe commented

Ooops

    <h2{{ title_attributes }}>
        <h2><a href="{{ node_url }}" rel="bookmark">{{ label }}</a></h2>
     </h2>

>>Had to reroll some things.

Reroll because my patch wouldn't apply or because you wanted to do additional cleanup?

I only ask b/c I expect to submit more patches over time and wouldn't want you to have to reroll every time.

chrisjlee’s picture

chrisjlee commented

@ergophobe: Had to reroll because i committed something and the patch wouldn't apply. I just did it manually. It's no problem. I copied most of it from your patch anyways. Keep them coming!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.