feedapi_inherit improvements [#195816]

+ faster
+ easier to configure
+ removes not scalable retroactive group / taxonomy assignment
- no retroactive group / taxonomy assignment any more.

This patch changes feedapi_inherit so that it triggers on hook_nodeapi, not on hook_feedapi_item(), therefore feedapi_inherit ...
... does not search for feed items by URL any more
... does not need to be weighted heavier than feedapi_node processor on content type configuration page any more

I removed the retroactive assigning of group or taxonomies because it didnt scale. Retroactive assigning means that changes on feeds have changes on *existing* feed items, not just future feed items. This functionality did not scale, because the PHP script timed out when too many feed items where associated with a feed.

Comment	File	Size	Author
	performance_feedapi_inhert.patch	7.88 KB	alex_b

Comments

Comment #1

alex_b commented 27 November 2007 at 23:23

Title:

Performance improvement and simplification of feedapi_inherit

» Performance improvem. and simplif. of feedapi_inherit

Comment #2

alex_b commented 27 November 2007 at 23:25

Title:

Performance improvem. and simplif. of feedapi_inherit

» feedapi_inherit improvements

better title

Comment #3

jbowman commented 10 December 2007 at 04:24

I tried this patch, something I see immediately is that now if I have the same url appearing in multiple feeds, I've lost the functionality of that node just getting more categories. Not sure if this was supposed to be happening with the previous version or not, but it was definitely handy.

Comment #4

alex_b commented 18 December 2007 at 18:53

Status:

Needs review

» Fixed

Patch committed.

@jbowman: The functionality you discribe was not intentional. However, I can see why it is useful. The previous approach was too slow for old installations with large feed items bases though (search on URL (text) across all feed items).

I will soon start working on cross feed duplicate handling (http://drupal.org/node/193909) - this feature will bring back inheriting tags from different feeds.