On my SSL site, vimeo won't load because it is trying to pull js from the vimeo server in http rather than https

In players/osmplayer/player/miniplayer/src/miniplayer.players.vimeo.js on line 149:
var src = 'http://player.vimeo.com/video/';

needs to change to:
var src = '//player.vimeo.com/video/';

On line 135 there is:
tag.src = 'http://a.vimeocdn.com/js/froogaloop2.min.js';

It didn't seem like https://a.vimeocdn.com/js/froogaloop2.min.js would work since it doesn't have a cert, so instead I copied the code to my local server. It doesn't look like there is very much code in the .js file, maybe you can just copy it into the miniplayer.players.vimeo.js file and the issue goes away.

For those trying to fix before the bug fix, I went into players/osmplayer/player/miniplayer/bin/miniplayer.compressed.js and players/osmplayer/player/bin/miniplayer.compressed.js and made the changes there. Otherwise you have to run the make file which looked like more effort than editing these files.

CommentFileSizeAuthor
#2 support-https.patch2.48 KBin0ni

Comments

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

Came across this error because i use the KB SSL Enforcer chrome extension and it basically causes vimeo to break (external play pause links dont work at all, and often the video doesnt even load). I had to create an exception to not force HTTPS for player.vimeo.com. I realize this is kind of a separate issue, but thought id mention, and follow this issue. Its ashame that their cdn doesnt support SSL :-/ we basically did as you said, and copied the froogaloop2 script to our theme folder, and added it to the page in an alter/preprocess script.

in0ni’s picture

in0ni commented
Issue summary: View changes
StatusFileSize
new support-https.patch2.48 KB

attached is a patch. you'd have to apply the patch, and update the compressed files.

in0ni’s picture

in0ni commented
Status: Active » Needs review
RonD’s picture

RonD commented

This issue is in the 7.x-2.2 version also. Any chance we can get the patch into a new dev version soon as I do not have the js compiler resources necessary to run makefile after applying the patches.

Thank you very much for a great module and feature set.