Drupal\aggregator\Plugin\aggregator\fetcher\DefaultFetcher doesn't handle 304's correctly, making the parser throw an error, "Invalid document end" on line 1.

CommentFileSizeAuthor
#3 drupal-aggregator-not-modified-1958642-3-test-only.patch1.02 KBtwistor
#3 drupal-aggregator-not-modified-1958642-3.patch1.81 KBtwistor
#1 drupal-aggregator-not-modified-1958642-1-test-only.patch1.02 KBtwistor
#1 drupal-aggregator-not-modified-1958642-1.patch1.81 KBtwistor

Comments

twistor’s picture

twistor commented
Status: Active » Needs review
StatusFileSize
new drupal-aggregator-not-modified-1958642-1.patch1.81 KB
new drupal-aggregator-not-modified-1958642-1-test-only.patch1.02 KB

Status: Needs review » Needs work

The last submitted patch, drupal-aggregator-not-modified-1958642-1.patch, failed testing.

twistor’s picture

twistor commented
Status: Needs work » Needs review
StatusFileSize
new drupal-aggregator-not-modified-1958642-3.patch1.81 KB
new drupal-aggregator-not-modified-1958642-3-test-only.patch1.02 KB

I am awesome. sigh

twistor’s picture

twistor commented

Darn, that test should fail.

I was having this problem while writing the test.

Apache is setting its own If-Modified-Since, and If-None-Match headers. Guzzle will then happily concatenate them. The feed ends up with an etag header like, h__lfVU1SyY-w28Xq0pfxb8gcBNeuD-43cpt_zIe98w, 12345678.This means they will never match in aggregator_test_feed() and there's no way to test this. I worked around it locally by hardcoding the If-None-Match header.

Not sure how to proceed from here.

alansaviolobo queued 3: drupal-aggregator-not-modified-1958642-3-test-only.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: drupal-aggregator-not-modified-1958642-3-test-only.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Assigned: twistor » Unassigned
Issue summary: View changes

This still a concern in D8? Unassigned issue too.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

The fix suggested in the latest patch was added to Drupal 8 in #1987598: Convert aggregator_test_feed() and aggregator_test_redirect() to a new style controller, so I think this is outdated. This is supported by the fact that way back in 2015 mgifford asked if this was still a problem and there has been not response.

Therefore, closing as outdated. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.

Thanks!