The cache-control header should specify a 'max-age' directive to inform proxies of the XML's cacheability [#1959468]

Hi,

We are currently experiencing a problem with varnish caching the XML sitemap for the default lifetime for a resource that does not specific a minimum cache lifetime.

Can a 'Cache-Control' header of 'max-age' be added ?

Attached is a simple patch that provides this.

Comment	File	Size	Author
#7	xmlsitemap-max-age-7.patch	743 bytes	klidifia
#3	xmlsitemap-max-age-3.patch	743 bytes	klidifia
	xmlsitemap-max-age.patch	787 bytes	wiifm

Issue fork xmlsitemap-1959468

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1959468-2.x changes, plain diff MR !75
Check out this branch for the first time

Check out existing branch, if you already have it locally
1959468-the-cache-control-header changes, plain diff MR !73
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

Anonymous (not verified) commented 2 April 2013 at 23:54

Category:

bug

» feature

Not a bug certainly.

Comment #2

chris matthews commented 12 January 2019 at 03:42

Issue summary:	View changes
Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

1 file was hidden/shown/deleted

Status	File	Size
hidden	xmlsitemap-max-age.patch	787 bytes

The 6 year old patch to xmlsitemap.pages.inc does not apply to the latest xmlsitemap 7.x-2.x-dev and if still applicable needs a reroll.

Checking patch xmlsitemap.pages.inc...
error: while searching for:
    exit;
  }

  $headers += array(
    'Content-type' => 'text/xml; charset=utf-8',
    //'Content-length' => filesize($file),
    'Last-modified' => $last_modified,
    'Etag' => $etag,
    'Expires' => gmdate(DATE_RFC1123, $mtime + variable_get('xmlsitemap_minimum_lifetime', 0)),
    'Cache-Control' => 'must-revalidate',
    'X-Robots-Tag' => 'noindex, follow',
  );


error: patch failed: xmlsitemap.pages.inc:79
error: xmlsitemap.pages.inc: patch does not apply