undefined variable "original" in commons_radioactivity_comment_update() [#1959494]

When editing an already existing own comment, and saving ones edits, the following error message is getting displayed at the top of page:

Notice: Undefined variable: original in commons_radioactivity_comment_update() (line 45 of [...]/profiles/commons/modules/contrib/commons_radioactivity/includes/incidents/commons_radioactivity.incidents_comment.inc).
Notice: Trying to get property of non-object in commons_radioactivity_comment_update() (line 45 of [...]/profiles/commons/modules/contrib/commons_radioactivity/includes/incidents/commons_radioactivity.incidents_comment.inc).

Experienced with: Drupal Commons 7.x-3.1+1-dev

This can be fixed by exchanging line 45 profiles/commons/modules/contrib/commons_radioactivity/includes/incidents/commons_radioactivity.incidents_comment.inc with this:

$comment_change = $comment->status + $comment->original->status;

Because that's the way how the original comment is saved within a comment object in Drupal 7 [source]. I have however not checked the logic behind calculating that sum, means I trust you folks that this is correct :)

Comment	File	Size	Author
#4	comment_update_error.png	95.01 KB	devin carlson
#4	comment_update_no_error.png	66.96 KB	devin carlson
#1	Undefined_Variable_Comment_Update-1959494-1.patch	795 bytes	stupiddingo

Comments

Comment #1

stupiddingo commented 14 May 2013 at 04:08

Status	File	Size
new	Undefined_Variable_Comment_Update-1959494-1.patch	795 bytes

This error also exists in Commons 7.x-3.2 and 7.x-3.x-dev

The solution tanius describes above works well. With this small fix, I'm not seeing anymore errors from comment editing, and works cleanly for all CRUD. Logic looks sound to me, and I suspect the $original->status was just a typo.

Patch attached for review.