Hi,

It make sense to me that the themeing of the flash objects be overwritable. That way us themers, can change a url, change the movie size, etc, without having to hack the module.... That way we can safely update the module when new releases occur.

For that reason I have attached a patch which separates out a theme function for youtube and another for google.

To test it would be just a matter of applying the patch , then adding a theme override function to the theme's template file for each of the 2 theme functions, and then modify some of the html, like the sizes, or the url.

arcX

CommentFileSizeAuthor
googtube.patch1.92 KBalexiscott

Comments

alexiscott’s picture

alexiscott commented
Assigned: alexiscott » Unassigned
Priority: Critical » Normal
alexandreracine’s picture

alexandreracine commented
Status: Needs review » Postponed (maintainer needs more info)

Hi, I'll look at this in a couple of days, but I don't have any 5.x Drupal to test it on right now. (I'll probably test it with D6).

Does the patch still apply or did you added more feature since November 2007? Thanks.

alexiscott’s picture

alexiscott commented

I haven't updated the patch since. I guess that the principle of the patch still would apply. So it should be pretty easy to reproduce just by adding those 2 theme functions. I think that it should also work with D6 as theme function overrides work in a similar way there I believe.

alexandreracine’s picture

alexandreracine commented
Status: Postponed (maintainer needs more info) » Needs review

I'll review this in the future.

alexandreracine’s picture

alexandreracine commented
Status: Needs review » Closed (works as designed)

I won't touch the D5 code so I'll leave it here.