Problem/Motivation

I have a need to customize node edit forms through Panels and Meta tags was unavailable as a form field there.

Proposed resolution

Add a ctools plugin for Panels.

Remaining tasks

I've added a patch which does just this, it could use review.

User interface changes

Adds a Meta tags form field to the panels form category.

CommentFileSizeAuthor
#8 metatag-n1959830-8.patch567 bytesdamienmckenna
#4 metatag-panels-node-edit-1959830-4.patch3.17 KBcarwin
#2 1959839-2-metatag-panels-node-edit.patch2.64 KBcarwin
#1 1959839-metatag-panels-node-edit.patch2.7 KBcarwin

Comments

carwin’s picture

carwin commented
StatusFileSize
new 1959839-metatag-panels-node-edit.patch2.7 KB

Here is the patch I neglected to add to the actual issue.

carwin’s picture

carwin commented
StatusFileSize
new 1959839-2-metatag-panels-node-edit.patch2.64 KB

That last patch was a bit sloppy, I left a dpm() call in there and also had some coding style bugaboos.
Heres a spruced up patch that applies so cleanly you could take a bath in it. Enjoy.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Did a quick review. Given the plugin is written to only work with nodes it needs to be renamed to e.g. metatag_node_form so that we can the also add metatag_user_form, metatag_term_form, etc.

carwin’s picture

carwin commented
StatusFileSize
new metatag-panels-node-edit-1959830-4.patch3.17 KB

That makes sense.

carwin’s picture

carwin commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

BTW you should take a look at https://drupal.org/sandbox/ceastwood/2009524 to see if it provides the same functionality as this patch, if so it might be better to combine efforts there?

drclaw’s picture

drclaw commented

Hello. I'm the maintainer of the sandbox project mentioned by @DamienMcKenna in comment #6. I just made it a full project and it does indeed do what he says. Here's the link to the project: https://drupal.org/project/node_form_panes

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n1959830-8.patch567 bytes

I think we should promote using node_form_panes to achieve this functionality instead of handling it within Metatag.

This patch is just an improvement to README.txt that mentions the new module.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.