getting Warning: Invalid argument supplied for foreach() in shs_taxonomy_term_update() (line 689 of /var/www/html/sites/all/modules/shs/shs.module) on node updates because some terms in hierarchy don't have a parent. patch to follow

CommentFileSizeAuthor
#8 checkifparentset-1960182-08-D7.patch439 bytestassos
#1 checkifparentset-1960182.patch914 bytesel1_1el

Comments

el1_1el’s picture

el1_1el commented
Assigned: Unassigned » el1_1el
Status: Active » Needs review
StatusFileSize
new checkifparentset-1960182.patch914 bytes

should work...

stborchert’s picture

stborchert
he/him
Primary language German
commented

I have committed a slightly modified version of your patch.
Thanks for your contribution.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Fixed

Forget to set status.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Makku01’s picture

Makku01 commented
Issue summary: View changes

Hi Stefan, is there any chance to get this patch committed?

kurkuma’s picture

kurkuma commented

The patch supplied was created on Windows and the line endings must be corrected if applied on a Linux machine.

manarth’s picture

manarth commented

For reference (in case like me, anyone's looking for this specific patch rather than updating to the latest dev branch), that fix was added in commit f39c5fb17ceb71054597ade03253bf09772a84da.

tassos’s picture

tassos commented
StatusFileSize
new checkifparentset-1960182-08-D7.patch439 bytes

As kukurma said the patch given has Windows line endings. When tried to apply with drush make it fails. The following patch has converted line endings to unix line endings.