Add more tests for Field config import

tagging

Actually, we test it for the body instance:

    foreach (array('article', 'page') as $node_type) {
      $config = config("field.instance.node.$node_type.body")->get();

So I think we're good imo.

right, duh, I need to learn to read titles.

Right, more fields, means more stuff to delete :)

Nice job!
Some nitpicks though:^

FieldImportCreateTest.php:

+    // A field with multiple instances.
+    $field_2 = entity_load('field_entity', $field_id);
+    $this->assertTrue($field, 'The second field was created.');

I think here should be

+    // A field with multiple instances.
+    $field_2 = entity_load('field_entity', $field_id_2);
+    $this->assertTrue($field_2, 'The second field was created.');

     // Check that the field and instance do not exist yet.
     $this->assertFalse(entity_load('field_entity', $field_id));
     $this->assertFalse(entity_load('field_instance', $instance_id));

This patch doesn't check $field_2 and $instance_2 before enabling field_test_config module.

It might be a good thing to add this multiple instances test in

  /**
   * Tests creating fields and instances during config import.
   */
  function testImportCreate() {

// Add the coresponding entries to the current manifest data.
This is not from the patch, but in the original code -- wrong word *corresponding*.

FieldImportDeleteTest.php:

+    $instance_id_2a = "test_entity.test_bundle.$field_id";
+    $instance_id_2b = "test_entity.test_bundle.$field_id_2";

I think you want $instance_id_2b to has a different bundle -- + $instance_id_2b = "test_entity.test_bundle_2.$field_id_2"; and $instance_id_2a has a different field id -- $field_id_2:)

-    // Check that the config was correctly imported.
-    $field = entity_load('field_entity', $field_id);
-    $this->assertTrue($field, 'The field was created.');
-    $instance = entity_load('field_instance', $instance_id);
-    $this->assertTrue($instance, 'The field instance was created.');

Any particular reason to delete these checks? In this test file, it uses $this->installConfig(array('field_test_config')); to enable configuration, different from

module_enable(array('field_test_config'));

in FieldImportCreateTest.php. I think it's necessary to add this check and for new field and instances in this patch.

-    $field_uuid = $field->uuid;
+    // Get the uuid's for the fields.
+    $field_uuid = entity_load('field_entity', $field_id)->uuid();
+    $field_uuid_2 = entity_load('field_entity', $field_id)->uuid();

Could be $field_uuid_2 = entity_load('field_entity', $field_id_2)->uuid();, although I prefer this way $field->uuid^^

Finally, while this patch creates a new field and two based different instances, I guess a second instance with a different bundle based on current field in these tests will be okay:)

Patch updated according to #10.

For 'uuid' in staging yml file, I used following code to generate them. Not sure I did it correctly.

use Drupal\Component\Uuid\Uuid;
$ob = new Uuid();
$uuid = $ob->generate();
dsm($uuid);
$uuid = $ob->generate();
dsm($uuid);
$uuid = $ob->generate();
dsm($uuid);

Fixed some bugs.

Needs a reroll

error: patch failed: core/modules/field/lib/Drupal/field/Tests/FieldImportDeleteTest.php:68
error: core/modules/field/lib/Drupal/field/Tests/FieldImportDeleteTest.php: patch does not apply

tagging.
also, instructions if someone new wants to try it: http://drupal.org/patch/reroll

This is good to go btw, mine was just a re-roll.

Manifests are gone as of #1998576: Make the config import process use full config trees again, so this needs work

And here's the reroll.

Committed 939a8a8 and pushed to 8.x. Thanks!